feat: enable support for Node.js projects requiring `build` step
Metadata
Current evaluation
Closed unmerged; Express/Node package.json build-step support was delivered instead by merged PR #1315 in commit b640dccd.
Resolution: closed superseded
Reason: PR #1309 received no review and was closed after 65 days with several CI jobs failing. The narrower implementation was merged through canonical/rockcraft#1315 at b640dccd, adding support for package.json build scripts.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Allow arbitrary project structure, not not /app directory.
Express/Node projects may require explicit `build` step, add extra logic to accommodate projects with `build` script defined.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; Express/Node package.json build-step support was delivered instead by merged PR #1315 in commit b640dccd. | |
| stealth/space-bunny-alpha | — | closed superseded | External PR adding Node.js/Express `build` step support was closed unmerged after ~65 days with review still pending and fast/source-spread/lint CI failing. The same feature landed instead via merged PR #1315 (commit b640dccd). | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged after 65 days without reviewer feedback; review was still pending, and fast tests, source-spread tests, and file lint were failing. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging due to failing CI checks and lack of reviewer feedback. The feature adding Node.js build step support was abandoned. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Superseded By:
canonical/rockcraft#1315
(confidence 98%)
Merged PR that implemented build-step handling for Express.js extensions in commit b640dccd.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1319 feat(extensions): handle ExpressJS build steps and bare bases | rockcraft | closed | Closed unmerged as a duplicate: ExpressJS build-step support landed in #1315 (commit b640dccd); the bare-base portion moved to follow-up #1320, which was merged. | |
| #1315 feat(extensions): handle build step for expressjs framework | rockcraft | merged | Merged in canonical/rockcraft#1315 (commit b640dccd), adding support for a package.json-defined `build` step (TypeScript, Vite, etc.) in the NodeJS/Express.js extension; prerequisite PR #1310 was also merged. |