feat(extensions): handle build step for expressjs framework
Metadata
Current evaluation
Merged in canonical/rockcraft#1315 (commit b640dccd), adding support for a package.json-defined `build` step (TypeScript, Vite, etc.) in the NodeJS/Express.js extension; prerequisite PR #1310 was also merged.
Resolution: closed resolved
Reason: The PR was approved by 5 reviewers and merged into main at commit b640dccd, landing Express.js `build` step handling in the NodeJS extension. Its stated dependency, PR #1310 (get_project_base() in Extension.validate()), was also merged, satisfying the test prerequisite; the sole failing check (source-spread-tests) did not block the merge.
Evaluated by: mr-cal-bot
No scores available.
Issue body
These changes introduce support for `build` step that may be defined in package.json file (typescript, vite, etc.)
Note: it requires PR#1310 to pass all tests.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#1315 (commit b640dccd), adding support for a package.json-defined `build` step (TypeScript, Vite, etc.) in the NodeJS/Express.js extension; prerequisite PR #1310 was also merged. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#1315 (commit b640dccd), adding package.json build-step support for Express.js extensions. Its prerequisite, PR #1310, was also merged. | |
| qwen/qwen3.6-35b-a3b | — | — | Added build step support for Express.js extensions by parsing package.json. Merged after PR #1310 dependency was resolved, five approvals, and passing CI checks. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
45
Confidence:
90
|
needs review | Adds build step support for ExpressJS framework via package.json configuration. Awaits CI execution and depends on PR#1310. Currently has 5 approvals and zero unresolved comments. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
50
Confidence:
90
|
needs review | Adds build step support for ExpressJS framework via package.json. Approved by five reviewers with zero unresolved comments. Awaits CI execution and dependency on PR#1310 for test validation. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
50
Confidence:
90
|
needs review | Adds build step support for Express.js framework by parsing package.json configurations. Currently approved by five reviewers with zero unresolved comments, awaiting CI execution or merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
50
Confidence:
85
|
needs review | Adds build step support for Express.js extensions by parsing package.json scripts. Currently approved by 5 reviewers with zero unresolved comments, awaiting CI execution and merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
40
Confidence:
90
|
needs review | Adds build step support for ExpressJS framework extensions by parsing package.json. Approved by 5 reviewers with zero unresolved comments, awaiting CI execution and merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
90
|
needs review | Adds build step support for Express.js extensions by parsing package.json. Currently approved by 5 reviewers with zero unresolved comments, ready for final merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
85
|
needs review | Adds support for a build step in package.json for the ExpressJS framework extension. Currently approved by five reviewers with one unresolved comment, awaiting final review and merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
85
|
needs review | Adds build step support for Express.js framework extensions by parsing package.json scripts. Currently approved by 5 reviewers with 1 unresolved comment, pending CI execution and a required dependency PR. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
85
|
needs review | Adds support for a build step in package.json for the ExpressJS framework extension. Currently approved by five reviewers with one unresolved comment, pending PR#1310 for CI, and awaiting maintainer review. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
50
Confidence:
85
|
needs review | Adds build step support for Express.js framework extensions by parsing package.json scripts. Currently approved by five reviewers with one unresolved comment, awaiting final validation and merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
40
Confidence:
90
|
needs review | Implements build step handling for ExpressJS extensions via package.json. Approved by five reviewers with zero unresolved comments, awaiting final maintainer review and merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
20
Complexity:
45
Confidence:
90
|
needs review | Adds build step support for Express.js extensions by parsing package.json scripts. Currently approved by five reviewers but has one unresolved comment and depends on PR #1310. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
85
|
needs review | Adds build step support for Express.js extensions by parsing package.json. Currently approved by 5 reviewers with 0 unresolved comments, awaiting CI execution. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
45
Confidence:
90
|
needs review | Adds build step support for the Express.js framework via package.json configuration. The PR has five approvals, zero unresolved comments, and is awaiting maintainer review and CI execution to proceed to merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
50
Confidence:
85
|
needs review | Adds support for a build step in package.json for the ExpressJS framework extension. Approved by 5 reviewers with 3 unresolved comments. Requires PR 1310 for tests. Awaiting maintainer review. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
50
Confidence:
85
|
needs review | Adds build step support for Express.js framework extensions. Currently approved by five reviewers but has four unresolved comments and depends on PR#1310. Recently pinged for review. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
45
Confidence:
85
|
needs review | Adds build step support for Express.js framework extensions by parsing package.json scripts. Currently approved by 5 reviewers but has 9 unresolved comments and requires PR #1310 to pass tests. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
45
Confidence:
85
|
needs review | Adds build step support for Express.js framework via package.json. Approved by 5 reviewers with 9 unresolved comments. Requires PR #1310 for CI. Currently awaiting final review/merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
85
|
needs review | Adds support for a configurable build step in the ExpressJS framework extension. The PR has 5 approvals, recent activity, and passes local lint/tests, but depends on PR#1310 for full CI validation. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
45
Confidence:
90
|
needs review | Adds build step support for Express.js framework extensions by parsing package.json scripts. Currently awaiting maintainer review with 5 unresolved comments and changes requested status. Requires PR #1310 to pass tests. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
90
|
needs review | Adds build step support for Express.js framework extensions. Currently pending maintainer review with 4 unresolved comments, and CI failing on source-spread-tests and lint. Requires PR#1310. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
50
Confidence:
85
|
needs review | Adds build step support for ExpressJS framework by parsing package.json. Currently under review with requested changes, two unresolved comments, and failing CI checks for source-spread-tests and lint/files. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
55
Confidence:
85
|
needs review | Adds build step support for ExpressJS framework via package.json configuration. Currently under review with changes requested by three reviewers. CI passes most checks but fails lint and spread tests. Depends on PR#1310. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
90
|
needs review | Adds build step support for Express.js framework by parsing package.json scripts. Currently pending maintainer review with changes requested, though CI passes and review comments are resolved. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
90
|
needs review | Adds build step support for ExpressJS framework via package.json configuration. Currently awaiting maintainer review with changes requested by three reviewers, while CI tests are still running. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
85
|
needs review | Adds build step support for ExpressJS framework extensions. Currently awaiting maintainer review with 8 unresolved comments and some failing CI checks. Requires PR #1310. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
55
Confidence:
85
|
needs review | Adds build step support for Express.js extensions via package.json. Currently under review with 8 unresolved comments, recent maintainer ping, and some failing CI checks. Requires PR #1310. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
85
|
needs review | Adds build step support for ExpressJS framework extensions. Currently under review with 8 unresolved comments and failing CI checks on lint, security scan, and spread tests. Requires PR #1310. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
55
Confidence:
85
|
needs review | Adds build step support for the ExpressJS framework extension. Currently awaiting maintainer review with 8 unresolved comments and pending CI checks. Requires PR #1310 to pass tests. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
85
|
needs review | Adds build step support for ExpressJS framework via package.json. Currently under review with 8 unresolved comments and minor CI failures. Awaits maintainer feedback and dependency resolution. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
50
Confidence:
90
|
needs review | Adds build step support for Express.js framework extensions by parsing package.json. Currently under review with 8 unresolved comments, 2 failing CI checks, and pending slow tests. Requires PR#1310. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
45
Confidence:
85
|
needs review | Adds build step support for Express.js extensions by parsing package.json. Currently under review with 8 unresolved comments, CI mostly passing, and blocked on PR #1310. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
50
Confidence:
85
|
keep open | Adds build step support for ExpressJS framework via package.json configuration. Currently under review with 8 unresolved comments, failing CI tests, and awaiting author updates. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
45
Confidence:
85
|
needs review | Adds build step support for ExpressJS framework extensions by parsing package.json scripts. Currently under review with 8 unresolved comments and some failing CI tests. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
5
Complexity:
45
Confidence:
85
|
needs review | Adds support for the build step in package.json for the ExpressJS framework extension. Currently pending CI checks and maintainer review. Requires PR#1310. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Blocked By:
canonical/rockcraft#1310
(confidence 95%)
PR body states 'it requires PR#1310 to pass all tests'; #1310 (fix: use get_project_base() in Extension.validate()) was merged first.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1309 feat: enable support for Node.js projects requiring `build` step | rockcraft | closed | Closed unmerged; Express/Node package.json build-step support was delivered instead by merged PR #1315 in commit b640dccd. | |
| #1319 feat(extensions): handle ExpressJS build steps and bare bases | rockcraft | closed | Closed unmerged as a duplicate: ExpressJS build-step support landed in #1315 (commit b640dccd); the bare-base portion moved to follow-up #1320, which was merged. |