← Back to issue list

style(ci): fix actionlint findings in schema and snap workflows

View original Github issue

Metadata

Project
rockcraft
Number
#1397
Type
pull request
State
merged
Author
dangertoaster
Labels
—
Created
Updated
Closed

Current evaluation

Fixed actionlint findings in schema.yaml and snap.yaml workflows via merged PR #1397 by removing a dangling cache-suffix, quoting variables, and replacing echo|sed with bash parameter expansion.

Resolution: closed resolved

Reason: The PR was merged, resolving the actionlint linting errors in the schema and snap workflows ahead of the Starbase sync.

Evaluated by: mr-cal-bot

No scores available.

Issue body

🤖 This message was generated by kimi-k3 ## What Fixes the findings that `actionlint` reports in the repo-owned workflows `schema.yaml` and `snap.yaml`. ## Why Preparation for the upcoming [Starbase](https://github.com/canonical/starbase) sync, which adds `.github/actionlint.yaml` and a `lint-actions` make target that runs `actionlint`. Without these fixes, that target fails on current `main`. ## How - `schema.yaml`: remove `cache-suffix: ${{ steps.runner-info.outputs.cache-hash }}`. The referenced `runner-info` step never existed in this workflow — the line was introduced dangling in 5c2c03a ("ci: fix schema diff with uv"), copied from craft-parts' `uv.yaml`, which does define such a step. The expression therefore always evaluated to an empty string, so removing the line is behavior-preserving. (The alternative — adding a `runner-info` step just to keep a no-op cache suffix — was rejected as unnecessary churn.) - `schema.yaml`: quote `$ROCKCRAFT_JSON` in the diff run block (SC2086). - `snap.yaml`: replace `echo | sed` with bash parameter expansion (SC2001) and quote the expansion (SC2086). Behavior preserved: strips `refs/heads/feature/`, else `refs/heads/`, else leaves the ref unchanged — matching the old `sed` logic for this workflow's `push: branches: [feature/**]` trigger. ## Verification `actionlint` (v1.7.x) run locally: `schema.yaml` and `snap.yaml` now report no issues. The only remaining findings across the repo are the `spread-enabled` self-hosted runner labels in the spread workflows, which the Starbase-provided `.github/actionlint.yaml` config file declares. Note: the "PR: Merge" label was not applied — the bot token lacks triage permissions on this repository.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Fixed actionlint findings in schema.yaml and snap.yaml workflows via merged PR #1397 by removing a dangling cache-suffix, quoting variables, and replacing echo|sed with bash parameter expansion.

Update history

Date Change
merged
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#5140 Add lint to schema snapcraft closed Lint support was added to snapcraft.yaml schemas, fixing editor errors and missing autocomplete via merged PR #5730 (commit 7cfb25977).
73%
#450 fix(ci): resolve actionlint findings in snap and spread-test workflows imagecraft closed Actionlint fixes from #450 landed as commit f9425e0 and were carried into main by merged Starbase PR #449 (545f51a), despite #450 itself being closed unmerged.
70%