fix(ci): resolve actionlint findings in snap and spread-test workflows
Metadata
Current evaluation
Actionlint fixes from #450 landed as commit f9425e0 and were carried into main by merged Starbase PR #449 (545f51a), despite #450 itself being closed unmerged.
Resolution: closed resolved
Reason: Commit f9425e0 records the workflow fixes and appears in main history through merged PR #449 (545f51a). PR #455 later adjusted the runner label from spread-installed to spread-enabled without undoing the actionlint fixes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Context
This is a **preparation PR** split out ahead of the Starbase merge PR (#449),
per the `update-starbase` skill's preparation-PR rules. Starbase's merge
introduces a new default-enabled `lint-actions` target (`common.mk`, wired
into `make lint`) backed by `.github/actionlint.yaml`. Running it exposed
pre-existing, unrelated issues in imagecraft's own workflow files that
predate the Starbase sync.
## Changes
- `snap.yaml`: quote `$GITHUB_OUTPUT` in two places (shellcheck SC2086), and
replace an `echo | sed` pipeline with parameter expansion (SC2001) to
derive the feature-branch name.
- `spread-test.yaml`:
- Fix the self-hosted runner label typo `spread-enabled` ->
`spread-installed` (the label declared in `.github/actionlint.yaml` and
used elsewhere for spread jobs).
- Quote `$GITHUB_ENV`/`$FAILED_TESTS_FILE` (SC2086).
- Suppress one SC2086 with an inline comment where a variable is
intentionally split into multiple command arguments.
None of these are logic changes; `actionlint` now passes cleanly against
both files.
🤖 [BEEP BOOP, A BOT WROTE THIS COMMENT - Claude Sonnet 4.5, GitHub Copilot Chat]
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Actionlint fixes from #450 landed as commit f9425e0 and were carried into main by merged Starbase PR #449 (545f51a), despite #450 itself being closed unmerged. | |
| stealth/space-bunny-alpha | — | closed stale | PR #450 was closed unmerged after actionlint and runner-label fixes passed available CI; build and two snap-builds checks remained pending. | |
| stealth/space-bunny-alpha |
Impact:
20
Quick Win:
14
Complexity:
15
Confidence:
94
Actionability:
80
|
needs review | Fixes actionlint findings and a spread runner-label typo in CI configuration. All completed checks pass; build and two snap-builds checks remain pending. |
Update history
| Date | Change |
|---|---|
| closed | |
| created |
Related work
-
Likely Fixed By:
canonical/imagecraft#449
(confidence 99%)
Merged as 545f51a and carried the #450 commit into main.
-
Related To:
canonical/imagecraft#455
(confidence 98%)
Commit 8d05774 later reverted the runner-label portion of #450 to spread-enabled.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2893 ci: fix actionlint findings ahead of Starbase merge | charmcraft | closed | Closed unmerged; its actionlint fixes were superseded by merged PR charmcraft#2897 and Starbase merge charmcraft#2899. | |
| #470 feat(lint): lint the Github actions with actionlint | starbase | closed | Closed unmerged; the same actionlint integration shipped via merged PR #473 (commit e385e9d), wiring the actionlint snap into starbase's default lint target. | |
| #602 ci(lint): Allow `spread-enabled` in actionlint runner labels | starbase | merged | Merged PR canonical/starbase#602 (approved, 1 file, +1/-0) added `spread-enabled` to self-hosted-runner.labels in .github/actionlint.yaml, fixing false actionlint failures for workflows using that runner label. | |
| #1397 style(ci): fix actionlint findings in schema and snap workflows | rockcraft | merged | Fixed actionlint findings in schema.yaml and snap.yaml workflows via merged PR #1397 by removing a dangling cache-suffix, quoting variables, and replacing echo|sed with bash parameter expansion. |