tests: check before handling rockcraft instances
Metadata
Current evaluation
Merged after two approvals and passing CI. Updates spread test cleanup to conditionally stop and delete rockcraft lxc instances, preventing errors when tests do not create them. (+5/-2 lines)
Suggested action: —
No scores available.
Issue body
The previous code always tried to stop/delete rockcraft-related lxc instances because all spread tests created them. Now we have spread tests that don't, so wrap the cleanup in an `if`.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals and passing CI. Updates spread test cleanup to conditionally stop and delete rockcraft lxc instances, preventing errors when tests do not create them. (+5/-2 lines) | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a test fix that wraps rockcraft LXC instance cleanup in a conditional check to prevent errors when spread tests do not create instances. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Wrapped rockcraft LXC instance cleanup in a conditional check to prevent errors on spread tests that do not create them, eliminating unnecessary deletion attempts. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #174 tests: check before handling rockcraft instances | rockcraft | merged | Merged a fix wrapping rockcraft LXC instance cleanup in an if condition to prevent errors when spread tests do not create instances. Approved by two reviewers, passed CI, and modified one file. | |
| #100 tests: print rockcraft log files on spread failure | rockcraft | merged | Merged: adds 11 lines to print rockcraft log files during spread test failures, improving debugging visibility. Approved by one reviewer and passed CI checks. | |
| #1304 test(spread): fix cross-test contamination | rockcraft | merged | Merged fix for spread test cross-contamination. Resolved by copying a clean rockcraft.yaml template at test start to isolate variants. Approved by two reviewers and passed CI checks. | |
| #102 test: update craftctl test | snapcraft-rocks | merged | Merged after two approvals and passing CI checks. Updates the spread test to validate the fix for snapcraft-rocks#33, modifying one file with seven added lines. | |
| #14 fix ci tests and drop 18.04 | craft-actions | merged | Merged after two approvals and passing CI. Fixed failing tests by removing deprecated fields from rockcraft.yaml and dropped Ubuntu 18.04 from the test matrix due to end of support. Modified 2 files with a net reduction of 2 lines. | |
| #400 fix(docs): make sure we can build the example rockcraft.yaml | rockcraft | merged | Merged to resolve issue #399. Added a spread test validating the example rockcraft.yaml build process for documentation. Approved by three reviewers and passed all CI checks. | |
| #1293 test: update 25.10 spread tests with --ignore=unmaintained | rockcraft | merged | Merged. Added --ignore=unmaintained to run_rockcraft pack commands across test task files to handle Ubuntu 25.10 EOL without removing scenarios. Updated one test to use Ubuntu 26.04. All CI checks passed. | |
| #869 feat: add 'test' command | rockcraft | merged | Merged. Added the 'test' CLI command and spread tests for rockcraft. Approved by two reviewers, passed CI checks, and introduced 276 lines across seven files to validate the command using hardcoded fixtures. | |
| #40 feat(rockcraft-pack): support rockcraft test | craft-actions | merged | Merged to integrate rockcraft test into the build workflow. The change handles implicit pack execution to avoid OCI Factory duplication. Approved by two reviewers, passed CI, and merged with 218 additions and 12 deletions. | |
| #115 ci: always discard spread workers in build-rock tests (core22-8) | snapcraft-rocks | merged | Merged changes adding a cleanup step to discard spread workers in the build-rock CI workflow. This prevents leaked Google Cloud VM instances on cancellation or crash, resolving SNAPCRAFT-1368. Approved by two reviewers. |