tests: check before handling rockcraft instances
Metadata
Current evaluation
Merged PR #173 added a presence check before Rockcraft LXC cleanup, preventing spread tests that create no Rockcraft instance from trying to stop or delete one.
Resolution: closed resolved
Reason: PR #173 was approved and merged. Its five-line change wraps LXC cleanup in a condition so it only runs when a Rockcraft-related instance exists.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The previous code always tried to stop/delete rockcraft-related lxc instances because all spread tests created them. Now we have spread tests that don't, so wrap the cleanup in an `if`.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #173 added a presence check before Rockcraft LXC cleanup, preventing spread tests that create no Rockcraft instance from trying to stop or delete one. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/rockcraft#174, guarding Rockcraft LXC cleanup so it only runs when a test creates an instance. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals and passing CI. Updates spread test cleanup to conditionally stop and delete rockcraft lxc instances, preventing errors when tests do not create them. (+5/-2 lines) | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a test fix that wraps rockcraft LXC instance cleanup in a conditional check to prevent errors when spread tests do not create instances. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #174 tests: check before handling rockcraft instances | rockcraft | merged | Merged PR #174 added an existence check before Rockcraft LXC instance cleanup, so spread tests that create no instances no longer fail during teardown. | |
| #100 tests: print rockcraft log files on spread failure | rockcraft | merged | Merged in commit 3a19387b: Spread failures now print the latest Rockcraft log for improved diagnostics. |