tests: check before handling rockcraft instances
Metadata
Current evaluation
Merged PR #174 added an existence check before Rockcraft LXC instance cleanup, so spread tests that create no instances no longer fail during teardown.
Resolution: closed resolved
Reason: PR #174 was approved by two reviewers and merged, wrapping instance stop/delete operations in a conditional check.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The previous code always tried to stop/delete rockcraft-related lxc instances because all spread tests created them. Now we have spread tests that don't, so wrap the cleanup in an `if`.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #174 added an existence check before Rockcraft LXC instance cleanup, so spread tests that create no instances no longer fail during teardown. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #173 conditionally checks for Rockcraft-related LXC instances before cleanup, avoiding failures in spread tests that do not create them. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix wrapping rockcraft LXC instance cleanup in an if condition to prevent errors when spread tests do not create instances. Approved by two reviewers, passed CI, and modified one file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix wrapping rockcraft LXC instance cleanup in a conditional check. This prevents errors on spread tests that do not create instances, completing #173 ahead of schedule. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/rockcraft#173
(confidence 98%)
Duplicate predecessor PR with the same title; the tracker states that #174 completed the cleanup change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #173 tests: check before handling rockcraft instances | rockcraft | closed | Merged PR #173 added a presence check before Rockcraft LXC cleanup, preventing spread tests that create no Rockcraft instance from trying to stop or delete one. | |
| #100 tests: print rockcraft log files on spread failure | rockcraft | merged | Merged in commit 3a19387b: Spread failures now print the latest Rockcraft log for improved diagnostics. | |
| #1304 test(spread): fix cross-test contamination | rockcraft | merged | Merged PR #1304: spread variants shared the python-from-chisel-bare dir, causing cross-test contamination; each test now copies a clean rockcraft.yaml template in first (+6 lines, 2 files). | |
| #98 Use `rockcraft test` to test the rocks | snapcraft-rocks | open | Maintainer-filed task to replace/augment spread tests in spread.yaml and CI workflows with `rockcraft test` so built snapcraft rocks are exercised; untouched for 421 days, no labels or discussion. |