← Back to issue list

parts: fix conversion of PartsError

View original Github issue

Metadata

Project
rockcraft
Number
#176
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/rockcraft#176 (ffeb4c89), fixing PartsError conversion to preserve craft-cli verbosity-based error reporting.

Resolution: closed resolved

Reason: The change maps PartsError.brief, details, and resolution into PartsLifecycleError instead of flattening str(err), restoring craft-cli's verbosity-based reporting. Evidence: merged PR #176, commit ffeb4c89.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The previous code was using the PartsError string representation (via str(err)) to populate a PartsLifecycleError's message. This has the effect of adding the original error's `details` into the message, which bypasses craft_cli's error reporting based on verbosity levels. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- (CRAFT-1538)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#176 (ffeb4c89), fixing PartsError conversion to preserve craft-cli verbosity-based error reporting.
stealth/space-bunny-alpha — closed resolved Merged in #176 (ffeb4c89): PartsError conversion no longer uses str(err) for PartsLifecycleError messages, so error details respect craft_cli verbosity reporting.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#176 (CRAFT-1538), preserving PartsError details in structured lifecycle error fields so craft_cli verbosity controls reporting.
qwen/qwen3.6-35b-a3b — — Merged fix for PartsError conversion that previously used string representation to populate PartsLifecycleError messages, bypassing craft_cli verbosity controls. Fixes error handling to properly respect verbosity levels.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for PartsError conversion. Using str(err) previously bypassed craft_cli verbosity reporting. The change ensures PartsLifecycleError properly respects verbosity levels. Resolves CRAFT-1538.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#314 docs: clean up references to Craft Parts rockcraft closed Craft Parts documentation cleanup was folded into canonical/rockcraft#308, merged as commit 13bf8368, and #314 was closed.
73%
#66 requirements: update craft-parts to 1.13.0 rockcraft merged canonical/rockcraft#66 merged as commit 6988715f, upgrading craft-parts to 1.13.0 and fixing #38 by eliminating unnecessary whiteout files.
72%
#763 fix: accept a 'pebble' part if its the same as ours rockcraft merged Merged in canonical/rockcraft#763 (commit d77ac5ac), accepting an existing Pebble part when identical to Rockcraft’s injected part and fixing expand-extensions builds.
71%
#441 fix: use correct error message for invalid version rockcraft merged Merged in canonical/rockcraft#441 (7955ba06), fixing misleading invalid-version errors by removing error_msg_templates and using transform_pydantic_errors; closes #429.
71%
#32 requirements: update dependencies rockcraft merged Merged in canonical/rockcraft#32 (commit 261961c1), updating dependencies to include the craft-parts symlink fix and resolve the stage-package installation failure in #28.
70%
#310 docs: fix url of rockcraft format rockcraft merged Merged in canonical/rockcraft#310 via commit 8145238e, correcting the Rockcraft format URL and resolving the convert-to-pebble-layer.rst linkcheck failure.
70%