fix: accept a 'pebble' part if its the same as ours
Metadata
Current evaluation
Merged in canonical/rockcraft#763 (commit d77ac5ac), accepting an existing Pebble part when identical to Rockcraft’s injected part and fixing expand-extensions builds.
Resolution: closed resolved
Reason: PR #763 explicitly fixes #749 and was merged as commit d77ac5ac. It allows an existing Pebble part to match Rockcraft’s injected part, resolving the duplicate-part build failure.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The use-case that this enables is packing the output of 'expand-extensions'. Previously, this would fail because the expanded yaml contains the 'pebble' part that Rockcraft adds, and then Rockcraft itself would complain that the project already has a part called 'pebble'.
This commit makes Rockcraft accept an existing part called 'pebble' if the contents of said part are the same as the one we would add.
Fixes #749
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#763 (commit d77ac5ac), accepting an existing Pebble part when identical to Rockcraft’s injected part and fixing expand-extensions builds. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #763 fixed #749 in commit d77ac5ac by accepting an existing pebble part when it matches Rockcraft's injected part. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#763 (commit d77ac5ac), allowing an identical existing pebble part and fixing the expand-extensions build failure tracked by #749. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix resolving a duplicate pebble part conflict during expand-extensions packing. Rockcraft now accepts an existing pebble part if its contents match the default, resolving issue #749. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix enabling Rockcraft to accept an existing 'pebble' part if its configuration matches the expected output. This resolves part name conflicts during 'expand-extensions' packaging and closes issue #749. |
Update history
No update history recorded yet.
Related work
-
Related To:
rockcraft#749
(confidence 100%)
PR #763 explicitly fixes the expand-extensions build failure reported in #749.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #749 Trying to build the output of "expand-extensions" fails because of the pebble part | rockcraft | closed | Fixed by PR #763 (commit d77ac5ac): expand-extensions output now accepts the injected default Pebble part when it matches Rockcraft's own configuration. | |
| #310 docs: fix url of rockcraft format | rockcraft | merged | Merged in canonical/rockcraft#310 via commit 8145238e, correcting the Rockcraft format URL and resolving the convert-to-pebble-layer.rst linkcheck failure. | |
| #176 parts: fix conversion of PartsError | rockcraft | merged | Merged in canonical/rockcraft#176 (ffeb4c89), fixing PartsError conversion to preserve craft-cli verbosity-based error reporting. | |
| #1210 fix(commands): reference rockcraft.yaml in extensions help | rockcraft | closed | PR #1210 (fix expand-extensions help to say rockcraft.yaml instead of snapcraft.yaml) was closed unmerged by its author as a duplicate of canonical/rockcraft#1103, which is already approved and CI-passing. | |
| #1170 missing sticky bit in PEBBLE_PATH | rockcraft | closed | Rockcraft now sets Pebble's default directory to mode 01777, adding the missing sticky bit; the fix was merged in canonical/rockcraft#1317 (88c7ae17). |