← Back to issue list

cli: parse command line using craft-cli

View original Github issue

Metadata

Project
rockcraft
Number
#26
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged as5c8a1bdd (merge58681bba) after 1 approval: rockcraft CLI now parses arguments via craft-cli's Dispatcher, replaces the temporary parser added in #2, and defines the pack command (+144/-197, 12 files).

Resolution: closed resolved

Reason: The PR itself was merged into main as commit 5c8a1bdd (merge commit 58681bba, branch cmatsuoka/integrate-cli-parsing), completing the craft-cli parsing integration requested. craft_cli imports (CommandGroup, Dispatcher) remain in rockcraft/cli.py today, confirming the change landed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Integrate craft-cli's command-line parsing subsystem and define the pack command, removing the temporary cli parser. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as5c8a1bdd (merge58681bba) after 1 approval: rockcraft CLI now parses arguments via craft-cli's Dispatcher, replaces the temporary parser added in #2, and defines the pack command (+144/-197, 12 files).
stealth/space-bunny-alpha — closed resolved PR canonical/rockcraft#26 merged after approval, adopting craft-cli for command-line parsing, removing the temporary parser, and defining the pack command.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Replaced the temporary CLI parser with craft-cli's subsystem and defined the pack command. Modified 12 files, adding 144 lines and removing 197.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Integrated craft-cli's command-line parsing subsystem and defined the pack command, replacing the temporary CLI parser. No comments or revisions were required.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#2 (confidence 88%)

    Earlier 'bootstrap minimal command line interface' PR whose temporary parser this work removed while keeping 'rockcraft pack'.

  • Related To: canonical/rockcraft#22 (confidence 72%)

    Prior PR 'cli: use craft-cli emit directly' in the same CLI rework series (commit f06f40d5).

  • Likely Fixed By: canonical/rockcraft#69 (confidence 45%)

    Later requirements bump to craft-cli 1.2.0 (commit f20530d9) continuing the dependency on the parser adopted here.

Related issues

Issue Project State Summary Similarity
#2 bootstrap minimal command line interface (CRAFT-571) rockcraft merged Merged PR #2 bootstrapping a minimal rockcraft CLI (CRAFT-571), +306/-11 across 12 files, just enough to run "rockcraft pack"; approved by one reviewer with no unresolved comments.
70%