tests: use the Craft CLI lib fixtures
Metadata
Current evaluation
Merged updates to replace test fixtures with the Craft CLI library version. Approved by one reviewer, modifying five files (+11/-54 lines). Resolves CRAFT-996.
Suggested action: —
No scores available.
Issue body
CRAFT-996
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to replace test fixtures with the Craft CLI library version. Approved by one reviewer, modifying five files (+11/-54 lines). Resolves CRAFT-996. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to use Craft CLI library fixtures for tests, resolving CRAFT-996. Maintainer facundobatista approved and integrated the pull request. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to update the test suite with fixtures from the Craft CLI library, resolving CRAFT-996. The update standardizes test dependencies and improves reliability. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3710 tests: use craft-cli lib fixtures | snapcraft | merged | Merged updates to use craft-cli library fixtures in tests. Approved, passed CI, and reduced test code by 89 lines across 11 files without affecting coverage. | |
| #754 Use the Craft CLI lib fixtures (CRAFT-995). | charmcraft | merged | Merged to implement CRAFT-995, switching to the Craft CLI lib fixtures. The update modifies three files with a net reduction of 148 lines. Approved by one reviewer and merged without comments. | |
| #653 feat!(test): add a pytest plugin | craft-application | merged | Merged a pytest plugin providing basic fixtures for craft-application and its consumers. Approved by two reviewers, passed CI checks, and updated 11 files (+350/-80 lines). Addresses CRAFT-4158. | |
| #3736 requirements: update dependencies | snapcraft | merged | Merged update bumping craft-cli to version 0.6.0. Approved by one reviewer with no unresolved comments. Changes modified two files (+4/-4 lines) with passing CI checks. | |
| #386 tests: update testing to use craft-test | fetch-service | merged | Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines). | |
| #1454 build: update craft-application | charmcraft | merged | Merged after updating the craft-application dependency and adjusting test constants. Approved by two reviewers with no unresolved comments. Changes affect three files with minor line adjustments. | |
| #102 test: update craftctl test | snapcraft-rocks | merged | Merged after two approvals and passing CI checks. Updates the spread test to validate the fix for snapcraft-rocks#33, modifying one file with seven added lines. | |
| #1123 tests: test craft-cli git | charmcraft | closed | A minor test update for craft-cli git was closed without merging. The two-line change received no reviews, CI checks, or comments, indicating the work was abandoned. | |
| #717 fix(test): minor test fixes | craft-application | merged | Merged minor test fixes replacing spread test pausing with a stream approach and adopting the new reroot key. Resolves issues #704 and #715, plus CRAFT-4399 and CRAFT-4411. Approved by two reviewers with all CI checks passing. | |
| #635 Use all functionality from craft-cli (CRAFT-710). | charmcraft | merged | Merged after approval. Integrated all craft-cli functionality, netting a reduction of 1724 lines across 11 files. Resolves CRAFT-710. |