← Back to issue list

tests: use craft-cli lib fixtures

View original Github issue

Metadata

Project
snapcraft
Number
#3710
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3710 under CRAFT-997, replacing local fixtures with craft-cli library fixtures across 11 files; merge commit 1f5901d8e.

Resolution: closed resolved

Reason: The test refactor was approved and merged into snapcraft/7.0 as commit 1f5901d8e, completing CRAFT-997.

Evaluated by: mr-cal-bot

No scores available.

Issue body

CRAFT-997

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3710 under CRAFT-997, replacing local fixtures with craft-cli library fixtures across 11 files; merge commit 1f5901d8e.
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#3710, replacing local test fixtures with craft-cli library fixtures across 11 files (+88/-177) under CRAFT-997.
qwen/qwen3.6-35b-a3b — — Merged updates to use craft-cli library fixtures in tests. Approved, passed CI, and reduced test code by 89 lines across 11 files without affecting coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Tests updated to use craft-cli library fixtures. Code coverage unchanged. Commit amended to comply with guidelines after a pylint fix.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#29 tests: use the Craft CLI lib fixtures rockcraft merged Merged #29 via commit 530542cd, replacing local test fixtures with Craft CLI library fixtures across five files for CRAFT-996.
93%
#754 Use the Craft CLI lib fixtures (CRAFT-995). charmcraft merged Merged #754 via 44df2fd7, replacing Charmcraft-local CLI test fixtures with Craft CLI library fixtures for CRAFT-995 (+19/−167).
87%
#309 tests: use fixture for base_configuration craft-providers merged Merged PR #309 as commit f4042c9, refactoring tests to use a reusable base_configuration fixture as a prerequisite for CRAFT-1767.
75%
#5375 test: fix command tests snapcraft merged Test-only PR by maintainer mr-cal merged as commit 28cb1b828 ("test: fix command tests (#5375)"), updating fixtures for failing command unit tests (CRAFT-4414); +17/-9 across 2 files, approved by 2 reviewers.
70%