← Back to issue list

tests: use craft-cli lib fixtures

View original Github issue

Metadata

Project
snapcraft
Number
#3710
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged updates to use craft-cli library fixtures in tests. Approved, passed CI, and reduced test code by 89 lines across 11 files without affecting coverage.

Suggested action: —

No scores available.

Issue body

CRAFT-997

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged updates to use craft-cli library fixtures in tests. Approved, passed CI, and reduced test code by 89 lines across 11 files without affecting coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Tests updated to use craft-cli library fixtures. Code coverage unchanged. Commit amended to comply with guidelines after a pylint fix.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0, the update replaces test fixtures with those from the craft-cli library. Codecov confirmed no coverage change. The commit was amended after a pylint fix before final merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#29 tests: use the Craft CLI lib fixtures rockcraft merged Merged updates to replace test fixtures with the Craft CLI library version. Approved by one reviewer, modifying five files (+11/-54 lines). Resolves CRAFT-996.
91%
#754 Use the Craft CLI lib fixtures (CRAFT-995). charmcraft merged Merged to implement CRAFT-995, switching to the Craft CLI lib fixtures. The update modifies three files with a net reduction of 148 lines. Approved by one reviewer and merged without comments.
81%
#1123 tests: test craft-cli git charmcraft closed A minor test update for craft-cli git was closed without merging. The two-line change received no reviews, CI checks, or comments, indicating the work was abandoned.
74%
#653 feat!(test): add a pytest plugin craft-application merged Merged a pytest plugin providing basic fixtures for craft-application and its consumers. Approved by two reviewers, passed CI checks, and updated 11 files (+350/-80 lines). Addresses CRAFT-4158.
73%
#102 test: update craftctl test snapcraft-rocks merged Merged after two approvals and passing CI checks. Updates the spread test to validate the fix for snapcraft-rocks#33, modifying one file with seven added lines.
72%
#386 tests: update testing to use craft-test fetch-service merged Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines).
71%
#635 Use all functionality from craft-cli (CRAFT-710). charmcraft merged Merged after approval. Integrated all craft-cli functionality, netting a reduction of 1724 lines across 11 files. Resolves CRAFT-710.
71%
#3910 unit tests: minor improvement to fixture usage snapcraft merged Merged into main after passing CI and review. The change refactors unit test fixture usage, modifying 8 lines across 2 files with zero impact on code coverage.
71%
#1381 fix: fix most spread tests on craft-application charmcraft merged Merged updates fixing most spread tests for craft-application. Two smoketests remain broken. Approved despite minor linting and unit test failures. Resolves CRAFT-2239.
70%