← Back to issue list

plugins: fix python shebang

View original Github issue

Metadata

Project
rockcraft
Number
#311
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for the Python shebang in plugins. The change replaces hardcoded interpreters with ${PARTS_PYTHON_INTERPRETER} to respect user overrides. Approved by two reviewers and merged.

Suggested action:

No scores available.

Issue body

Use ${PARTS_PYTHON_INTERPRETER} to play nice with the upstream plugin; If the user overrides this, there's probably a good reason (like using Python 3.6).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for the Python shebang in plugins. The change replaces hardcoded interpreters with ${PARTS_PYTHON_INTERPRETER} to respect user overrides. Approved by two reviewers and merged.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for the Python shebang in plugins by using the ${PARTS_PYTHON_INTERPRETER} variable. This respects user overrides like Python 3.6 and maintains compatibility with the upstream plugin.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for the python shebang in plugins. The change uses ${PARTS_PYTHON_INTERPRETER} instead of a hardcoded path to respect user overrides, such as specifying Python 3.6.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#830 python plugin: only replace proper shebangs. snapcraft merged Merged a python plugin fix that restricts shebang replacement to file beginnings. Approved by one reviewer, the change resolves plainbox snap conflicts with a +6/-1 diff across two files.
78%
#2112 repo: fix all python shebangs in stage-packages snapcraft merged Merged fix aligns Python shebang replacement in stage-packages with standard plugin behavior, applying it throughout the entire part instead of only bin directories. Removes sitecustomize.py to prevent part clashes. Resolves LP: #1766662.
75%
#389 plugins: refactor python plugin for subclassing craft-parts merged Merged a refactor of the Python plugin to enable subclassing and method overriding for custom interpreter location logic. Approved by one reviewer, passed CI checks, and modified three files.
75%
#392 plugins: fix pip path in python plugin craft-parts merged Merged a fix ensuring the python plugin uses the venv pip path, preventing unintended package installations when PATH changes. Approved by one reviewer, passed CI checks, and modified five files.
74%
#680 Rewrite shebangs generated by the python plugins. snapcraft merged Merged changes that rewrite Python plugin shebangs to use env instead of hardcoded paths, resolving Launchpad bug #1597919. After adding requested integration tests, the changes were approved and merged across 13 files.
74%
#384 plugins: refactor python plugin for subclassing craft-parts merged Merged after review and CI approval. Refactored the Python plugin to enable subclassing and method overriding, allowing custom logic for determining the interpreter location. Rebased on main prior to merge.
74%
#823 plainbox-provider plugin: rewrite python shebangs snapcraft merged Merged rewrite of Python shebangs in the plainbox-provider plugin to use /usr/bin/env python. Approved by two reviewers across five files. Resolves LP: #1626587. Missing unit tests were noted but acknowledged as unavailable.
71%