← Back to issue list

plugins: fix python shebang

View original Github issue

Metadata

Project
rockcraft
Number
#311
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #311 in commit 08e6a28c, replacing hardcoded plugin Python shebangs with ${PARTS_PYTHON_INTERPRETER} so interpreter overrides are honored.

Resolution: closed resolved

Reason: The approved PR was merged into main as commit 08e6a28c, fixing Python shebangs across 12 files and allowing overrides such as Python 3.6.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Use ${PARTS_PYTHON_INTERPRETER} to play nice with the upstream plugin; If the user overrides this, there's probably a good reason (like using Python 3.6).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #311 in commit 08e6a28c, replacing hardcoded plugin Python shebangs with ${PARTS_PYTHON_INTERPRETER} so interpreter overrides are honored.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#311 (08e6a28c), replacing hardcoded plugin Python shebangs with ${PARTS_PYTHON_INTERPRETER}.
qwen/qwen3.6-35b-a3b — — Merged a fix for the Python shebang in plugins. The change replaces hardcoded interpreters with ${PARTS_PYTHON_INTERPRETER} to respect user overrides. Approved by two reviewers and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for the Python shebang in plugins by using the ${PARTS_PYTHON_INTERPRETER} variable. This respects user overrides like Python 3.6 and maintains compatibility with the upstream plugin.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#384 plugins: refactor python plugin for subclassing craft-parts merged Merged PR #384 as commit ce664e69, making the Python plugin subclassable so applications can override interpreter-location logic.
76%
#6411 The Python plugin can create conflicting interpreters snapcraft closed Closed as fixed by merged PR #6437 (commit 35853fff8): the Python plugin now rewrites shebangs on core26+ to the absolute /snap/<name>/bin/python3 path, removing PATH-order ambiguity with staged /usr/bin/python3.
75%
#389 plugins: refactor python plugin for subclassing craft-parts merged Merged PR #389 in commit b23e45b2, refactoring the Python plugin so applications can subclass it and override interpreter-location logic.
75%
#680 Rewrite shebangs generated by the python plugins. snapcraft merged Merged PR #680 as commit 066d653b5, rewriting Python plugin shebangs to use env instead of absolute paths and fixing LP #1597919.
74%
#830 python plugin: only replace proper shebangs. snapcraft merged Merged as commit 60e29ef1b, restricting Python plugin shebang replacement to file beginnings and fixing LP #1626587-related plainbox conflicts.
72%