python plugin: only replace proper shebangs.
Metadata
Current evaluation
Merged as commit 60e29ef1b, restricting Python plugin shebang replacement to file beginnings and fixing LP #1626587-related plainbox conflicts.
Resolution: closed resolved
Reason: PR #830 was approved and merged as commit 60e29ef1b. The reporter confirmed that the plainbox snap conflicts were resolved.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Only replace shebangs at the beginning of a file.
LP: #1626587
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 60e29ef1b, restricting Python plugin shebang replacement to file beginnings and fixing LP #1626587-related plainbox conflicts. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #830 as 60e29ef1b, restricting Python shebang replacement to file beginnings and fixing LP #1626587. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #830 as commit 60e29ef1b, limiting Python plugin shebang replacement to file beginnings and resolving LP #1626587. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a python plugin fix that restricts shebang replacement to file beginnings. Approved by one reviewer, the change resolves plainbox snap conflicts with a +6/-1 diff across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. The python plugin now restricts shebang replacement to file beginnings, resolving plainbox snap conflicts tracked in LP #1626587. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#823
(confidence 90%)
Earlier plainbox-provider shebang rewrite for the same LP #1626587 problem.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1626587 plainbox-provider plugin python shebangs are mismatched | snapcraft (launchpad) | closed | Fixed by merged PR #823 (a7771b8e4), adding plainbox-provider shebang rewriting; PR #830 (60e29ef1b) then narrowed Python-plugin rewriting and removed remaining conflicts. | |
| #680 Rewrite shebangs generated by the python plugins. | snapcraft | merged | Merged PR #680 as commit 066d653b5, rewriting Python plugin shebangs to use env instead of absolute paths and fixing LP #1597919. | |
| #823 plainbox-provider plugin: rewrite python shebangs | snapcraft | merged | Merged as a7771b8e4: added shebang rewriting to the plainbox-provider plugin so installed Python scripts use the in-snap interpreter, fixing LP #1626587. Approved despite 4 unresolved review comments. | |
| #311 plugins: fix python shebang | rockcraft | merged | Merged PR #311 in commit 08e6a28c, replacing hardcoded plugin Python shebangs with ${PARTS_PYTHON_INTERPRETER} so interpreter overrides are honored. |