← Back to issue list

build: set snap grade based on version

View original Github issue

Metadata

Project
rockcraft
Number
#427
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #427 via commit 91214e03, setting snap grade from the build version: post versions are devel and other versions are stable.

Resolution: closed resolved

Reason: PR canonical/rockcraft#427 was approved and merged as commit 91214e03, adding the version-based snap grade assignment.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- When fixing this in charmcraft I noticed that it wasn't getting properly set in rockcraft.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #427 via commit 91214e03, setting snap grade from the build version: post versions are devel and other versions are stable.
stealth/space-bunny-alpha — closed resolved Merged PR #427 as commit 91214e03, adding snap grade assignment based on the project version to match Charmcraft behavior.
stealth/space-bunny-alpha — closed resolved Merged PR #427 as commit 91214e03, adding version-based snap grade assignment to Rockcraft so devel/edge snaps get the correct grade, mirroring the charmcraft fix.
stealth/space-bunny-alpha — closed resolved Merged PR #427 as commit 91214e03, adding version-based snap grade assignment to Rockcraft to match Charmcraft.
qwen/qwen3.6-35b-a3b — — Merged a one-line update to set the snap grade based on the version in rockcraft, resolving a parity gap with charmcraft. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged change implementing version-based snap grade configuration for rockcraft. The fix addresses a missing grade setting identified during a charmcraft update, ensuring consistent behavior across both tools.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1402 (confidence 90%)

    A parallel Charmcraft fix motivated the Rockcraft change and implemented the same devel-versus-stable version rule.

Related issues

Issue Project State Summary Similarity
#1402 build: set grade based on version number charmcraft merged Merged PR #1402 as a968adfa, setting the snap grade to devel for post versions and stable otherwise, resolving #1401.
91%
#2230 snap: use set-version and set-grade snapcraft merged Merged PR #2230 as commit e1b59b75, updating snap handling to use set-version and set-grade and resolving Launchpad bug #1789695.
79%
#1401 snapcraft.yaml: set grade dynamically charmcraft closed Dynamic snap grade was implemented by merged PR #1402 (commit a968adfa), assigning devel grade to post-releases and stable otherwise.
78%
#114 snap: set grade to stable fetch-service merged Merged in #114 via commit c7b9a39, setting the Snap grade to stable so releases can target the candidate channel.
78%
#440 fix: Set imagecraft snap grade dynamically from version metadata imagecraft closed Merged in #440, dynamically setting the snap grade to devel for post/dev versions and stable for tagged releases, fixing #439.
75%
#1618123 Add a build grade attribute to snaps snapcraft (launchpad) closed Grade support was merged in canonical/snapcraft#764 (commit 2e97ae2f4) and later documented in canonical/snapcraft#857.
72%
#2064 Support for set-grade snapcraft closed Added snapcraftctl set-grade support in merged PR #2067 (commit 4713f4ae3), including final snap metadata and schema validation, resolving #2064.
71%
#439 Dynamically set snap grade imagecraft closed Fixed by PR #440, which dynamically sets imagecraft's snap grade from version metadata (devel for dev/post versions, stable for tagged releases).
71%