← Back to issue list

snap: use set-version and set-grade

View original Github issue

Metadata

Project
snapcraft
Number
#2230
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2230 as commit e1b59b75, updating snap handling to use set-version and set-grade and resolving Launchpad bug #1789695.

Resolution: closed resolved

Reason: PR #2230 was approved and merged into master as commit e1b59b75. Its change implements set-version and set-grade handling and addresses Launchpad bug #1789695.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1789695 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2230 as commit e1b59b75, updating snap handling to use set-version and set-grade and resolving Launchpad bug #1789695.
stealth/space-bunny-alpha — closed resolved Merged PR #2230 in commit e1b59b75b, updating snap handling to use set-version and set-grade and resolving Launchpad #1789695.
stealth/space-bunny-alpha — closed resolved Merged PR #2230 in commit e1b59b75, updating snap handling to use set-version and set-grade and resolving Launchpad bug #1789695.
qwen/qwen3.6-35b-a3b — — Merged updates to snap handling that implement set-version and set-grade commands, resolving Launchpad bug #1789695. Approved by reviewer, passed CI, and increased test coverage by 0.01%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master, updating snap metadata handling to use set-version and set-grade commands per Launchpad bug #1789695. Changes passed all tests and increased code coverage by 0.01%.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2063 (confidence 90%)

    Earlier PR that introduced snapcraftctl set-version support used by this change.

Related issues

Issue Project State Summary Similarity
#427 build: set snap grade based on version rockcraft merged Merged in #427 via commit 91214e03, setting snap grade from the build version: post versions are devel and other versions are stable.
79%
#1402 build: set grade based on version number charmcraft merged Merged PR #1402 as a968adfa, setting the snap grade to devel for post versions and stable otherwise, resolving #1401.
79%
#114 snap: set grade to stable fetch-service merged Merged in #114 via commit c7b9a39, setting the Snap grade to stable so releases can target the candidate channel.
78%
#2064 Support for set-grade snapcraft closed Added snapcraftctl set-grade support in merged PR #2067 (commit 4713f4ae3), including final snap metadata and schema validation, resolving #2064.
74%
#2067 many: add snapcraftctl set-grade snapcraft merged Merged PR #2067 in commit 4713f4ae3, adding snapcraftctl set-grade and validating final snap.yaml metadata; resolves #2064.
73%
#1401 snapcraft.yaml: set grade dynamically charmcraft closed Dynamic snap grade was implemented by merged PR #1402 (commit a968adfa), assigning devel grade to post-releases and stable otherwise.
72%
#440 fix: Set imagecraft snap grade dynamically from version metadata imagecraft closed Merged in #440, dynamically setting the snap grade to devel for post/dev versions and stable for tagged releases, fixing #439.
70%