← Back to issue list

snap: use set-version and set-grade

View original Github issue

Metadata

Project
snapcraft
Number
#2230
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged updates to snap handling that implement set-version and set-grade commands, resolving Launchpad bug #1789695. Approved by reviewer, passed CI, and increased test coverage by 0.01%.

Suggested action:

No scores available.

Issue body

LP: #1789695 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged updates to snap handling that implement set-version and set-grade commands, resolving Launchpad bug #1789695. Approved by reviewer, passed CI, and increased test coverage by 0.01%.
qwen3.6-35b-a3b-mtp-q6 Merged into master, updating snap metadata handling to use set-version and set-grade commands per Launchpad bug #1789695. Changes passed all tests and increased code coverage by 0.01%.
qwen3.6-35b-a3b-mtp-q6 Merged into master, updating snap metadata handling to use set-version and set-grade. Addresses LP #1789695 and increases code coverage by 0.01%. Integrated by maintainer sergiusens after passing static and unit tests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#114 snap: set grade to stable fetch-service merged Merged after approval by two reviewers. Sets the snap grade to stable to enable candidate channel releases. The commit contained zero line changes.
76%
#427 build: set snap grade based on version rockcraft merged Merged a one-line update to set the snap grade based on the version in rockcraft, resolving a parity gap with charmcraft. Approved by two reviewers and passed CI checks.
76%
#2067 many: add snapcraftctl set-grade snapcraft merged Merged. Introduces snapcraftctl set-grade for scriptlet-based snap grade configuration and adds final YAML validation before snap.yaml generation. Resolves #2064. Approved, passed CI, and modified 20 files.
74%
#3325 snapcraftctl: add checks for empty string for set-version & set-grade snapcraft merged Merged validation checks for empty strings in snapcraftctl set-version and set-grade. Empty inputs previously caused cryptic metadata errors. The change now explicitly rejects invalid values with clear error messages. Approved and merged.
70%