← Back to issue list

chore(linter): fix some format errors

View original Github issue

Metadata

Project
rockcraft
Number
#446
Type
pull request
State
open
Author
syu-w
Labels
—
Created
Updated
Closed
—

Current evaluation

Whitespace-only ruff format fixes across 54 files; approved but 8 unresolved review comments and no activity for 418 days.

Suggested action: close superseded

Reason: Approved but with 8 unresolved review comments and no activity for 418 days; later autoformat commits (e.g. e12e93bd 'style: fix formatting with new ruff', 7eec7a29 'chore: run make autoformat') have already reformatted the codebase, superseding this whitespace-only PR.

Evaluated by: mr-cal-bot

Impact: 15 Quick Win: 2 Complexity: 25 Confidence: 55 Actionability: 20

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 2
Complexity: 25
Confidence: 55
Actionability: 20
close superseded Whitespace-only ruff format fixes across 54 files; approved but 8 unresolved review comments and no activity for 418 days.
stealth/space-bunny-alpha
Impact: 8
Quick Win: 1
Complexity: 22
Confidence: 78
Actionability: 12
close stale Whitespace-only ruff/linter format fixes across 54 files (+200/-210), opened Dec 2023 by maintainer syu-w. Approved by tigarmo but 8 unresolved review comments remain and no activity for 413 days.
stealth/space-bunny-alpha
Impact: 6
Quick Win: 1
Complexity: 22
Confidence: 74
Actionability: 18
close stale Whitespace-only linter format fixes across 54 files (+200/-210). Approved by tigarmo, but 8 unresolved review comments, no CI checks, and no activity for 411 days; branch has long diverged from main.
qwen/qwen3.6-35b-a3b
Impact: 5
Quick Win: 1
Complexity: 10
Confidence: 65
Actionability: 20
close superseded Formatting fix across 54 files with pure whitespace changes. Approved by 1 reviewer but has 8 unresolved comments. Inactive for 400 days.
qwen3.6-35b-a3b-mtp-q6
Impact: 15
Quick Win: 11
Staleness: 75
Complexity: 25
Confidence: 60
needs review Linter formatting fix across 54 files. Approved by 1 reviewer but has 8 unresolved review comments. Last activity 386 days ago.
qwen/qwen3.8-27b
Impact: 5
Quick Win: 4
Staleness: 85
Complexity: 10
Confidence: 65
close stale Pure whitespace/formatting fix across 54 files, approved but with 8 unresolved review comments. Inactive since Dec 2023; superseded by multiple subsequent autoformat commits (ruff format, prettier, make autoformat) that resolved the same formatting issues.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 15
Confidence: 90
close stale Fixes formatting errors across 54 files. Approved by one reviewer but has 8 unresolved comments and no CI checks. Inactive for over a year.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 5
Confidence: 90
close stale Addresses linter formatting errors with whitespace-only changes. Inactive for over a year with unresolved reviewer concerns about diff readability. Likely outdated due to linter updates.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 5
Confidence: 80
close stale Addresses minor linter and whitespace formatting fixes. Inactive for over a year with no recent maintainer feedback or CI status.

Update history

No update history recorded yet.

Related work

  • Related To: rockcraft#443 (confidence 70%)

    Companion linter cleanup PR merged earlier; #446 is the format-error counterpart.

Related issues

Issue Project State Summary Similarity
#1099 chore: fix linting craft-application merged Merged as 4c674c21, updating two files to clear Ty unused-directive lint errors; lint/files passed and review was approved.
77%
#115 chore(deps): update ruff and fix linting issue craft-application merged Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking.
76%
#1121 chore: minor cleanup craft-application closed PR #1121 was closed unmerged after 80 days; it received no reviews and the Canonical CLA check failed.
76%
#2028 chore: two small non-code changes charmcraft merged Merged PR #2028 incorporated two small non-code updates across two files (+5/-2), with approval from two reviewers.
76%
#585 chore(linter): misc fixes craft-parts merged Merged PR #585 with miscellaneous linter fixes across 125 files, preserving individual commits rather than squashing, as requested.
76%
#359 chore(lint): update linters and fix linting issues with new rules craft-parts merged Merged PR #359 in commit e7b93bde, updating linters and fixing violations introduced by the new rules across 13 files.
75%
#443 chore(linter): fix some annotation errors rockcraft merged Merged canonical/rockcraft#443 to fix linter annotation errors across 14 files (+97/-55); the maintainer-authored change was approved by two reviewers.
74%
#36 chore: switch to ruff craft-platforms merged Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files.
74%
#2896 chore: fix ruff, mypy, and pyright findings ahead of Starbase merge charmcraft closed PR #2896 was closed unmerged with no replacement; lint and OSV checks remained failing and review was still pending.
74%
#375 chore(lint): Remove trailing whitespace rockcraft merged Merged PR #375 removed trailing whitespace from one file (+4/-4), resolving yamllint complaints; landed as commit 777df7e3.
73%