← Back to issue list

chore: fix linting

View original Github issue

Metadata

Project
craft-application
Number
#1099
Type
pull request
State
merged
Author
smethnani
Labels
Created
Updated
Closed

Current evaluation

Merged a linting fix to resolve unused directives flagged by Ty. The update modified two files, received approval from two reviewers, passed CI validation, and was successfully integrated.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Ty is complaining about [unused directives](https://github.com/canonical/craft-application/actions/runs/28026620275/job/82955928823?pr=1091)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a linting fix to resolve unused directives flagged by Ty. The update modified two files, received approval from two reviewers, passed CI validation, and was successfully integrated.
qwen3.6-35b-a3b-mtp-q6
Staleness: 0
Complexity: 5
Confidence: 90
needs review Fixes Ty linter warnings about unused directives. Submitted by a maintainer, currently awaiting CI checks and initial review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#369 chore: fix linting imagecraft merged Merged after resolving redundant casting linting errors flagged by Ty. Approved by two reviewers. Changes involved minimal edits (+2/-2 lines) across one file. CI lint and test checks passed prior to merge.
91%
#359 chore(lint): update linters and fix linting issues with new rules craft-parts merged Merged after updating linters and fixing linting issues under new rules. The change modified 13 files and was approved by one reviewer before integration.
86%
#443 chore(linter): fix some annotation errors rockcraft merged Merged maintainer changes that resolved linter annotation errors across 14 files. The +97/-55 line update received approval from two reviewers and was successfully integrated into the codebase.
82%
#1215 chore: linting rockcraft merged Merged a linting fix replacing an unnecessary str() call with a string literal in tests/unit/test_project.py to resolve ruff error UP018. Approved by two reviewers and merged.
81%
#375 chore(lint): Remove trailing whitespace rockcraft merged Merged changes removing trailing whitespace from one file to satisfy linters like yamllint. Approved by two reviewers, passed CI, and modified four lines.
80%
#585 chore(linter): misc fixes craft-parts merged Merged linter fixes across 125 files. Approved by two reviewers and merged without squashing per maintainer request.
80%
#439 chore(linter): misc fix rockcraft merged Merged linter chore PR fixing miscellaneous issues and an unexpected pyright error from a rebase onto main. Approved by two reviewers, changes span 16 files with 86 additions and 76 deletions.
79%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
78%
#907 chore(merge): 2.1.3 into main craft-parts merged Merged version 2.1.3 into main following approval from two reviewers and passing CI checks. The change updated seven files, adding 36 lines and removing 10.
78%
#183 chore: make pre-commit linters use lint group for renovate starbase merged Merged a chore PR configuring pre-commit linters to use the lint group for Renovate. The single-file change (+3/-3 lines) passed CI, received one approval, and was successfully integrated.
78%