← Back to issue list

chore: fix linting

View original Github issue

Metadata

Project
craft-application
Number
#1099
Type
pull request
State
merged
Author
smethnani
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 4c674c21, updating two files to clear Ty unused-directive lint errors; lint/files passed and review was approved.

Resolution: closed resolved

Reason: PR #1099 was merged as commit 4c674c21. The change resolved Ty's unused-directive lint errors, and the lint/files CI check passed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Ty is complaining about [unused directives](https://github.com/canonical/craft-application/actions/runs/28026620275/job/82955928823?pr=1091)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 4c674c21, updating two files to clear Ty unused-directive lint errors; lint/files passed and review was approved.
stealth/space-bunny-alpha — closed resolved Merged PR #1099 in commit 4c674c21, removing unused Ty directives and fixing the reported lint failure.
stealth/space-bunny-alpha — closed resolved Merged PR #1099 via commit 4c674c21, fixing Ty's unused-directive lint errors with a small documentation cleanup.
qwen/qwen3.6-35b-a3b — — Merged a linting fix to resolve unused directives flagged by Ty. The update modified two files, received approval from two reviewers, passed CI validation, and was successfully integrated.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#369 chore: fix linting imagecraft merged Merged PR #369 removed two redundant casts (1 file, +2/-2), fixing Ty linting; the lint/files check passed.
86%
#529 chore: fix doc and yaml linting craft-parts merged Merged #529 as commit 81dc87bd, fixing documentation and YAML linting in three files. Verification used tox -m lint; lint enforcement in CI remained disabled.
78%
#359 chore(lint): update linters and fix linting issues with new rules craft-parts merged Merged PR #359 in commit e7b93bde, updating linters and fixing violations introduced by the new rules across 13 files.
77%
#446 chore(linter): fix some format errors rockcraft open Whitespace-only ruff format fixes across 54 files; approved but 8 unresolved review comments and no activity for 418 days.
77%
#2028 chore: two small non-code changes charmcraft merged Merged PR #2028 incorporated two small non-code updates across two files (+5/-2), with approval from two reviewers.
77%
#375 chore(lint): Remove trailing whitespace rockcraft merged Merged PR #375 removed trailing whitespace from one file (+4/-4), resolving yamllint complaints; landed as commit 777df7e3.
76%
#115 chore(deps): update ruff and fix linting issue craft-application merged Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking.
75%
#6431 chore(merge): 9.1.2 into main snapcraft closed Merged release branch 9.1.2 into main via commit 264420ba4; the remaining lint/files failure was attributed to an unrelated ty update.
75%
#1776 chore: remove unused code charmcraft merged Merged PR #1776 as commit 027696be, deleting 17,571 lines of unused code across 36 files after maintainer review and approval.
75%
#585 chore(linter): misc fixes craft-parts merged Merged PR #585 with miscellaneous linter fixes across 125 files, preserving individual commits rather than squashing, as requested.
75%