← Back to issue list

cleanup: don't write test files in cwd

View original Github issue

Metadata

Project
rockcraft
Number
#51
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged a cleanup fix that isolates test data using tmp_path instead of writing to the current working directory. This keeps make test-units output clean. Approved by one reviewer and changed one file.

Suggested action:

No scores available.

Issue body

Use "tmp_path" to isolate test data and keep the result of "make test-units" clean. I want to do some more cleaning-up but I figured I'd get this 'easy' fix out of the way

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a cleanup fix that isolates test data using tmp_path instead of writing to the current working directory. This keeps make test-units output clean. Approved by one reviewer and changed one file.
qwen3.6-35b-a3b-mtp-q6 Merged a cleanup change that redirects test file output to pytest's tmp_path fixture instead of the current working directory. This isolates test artifacts and keeps the make test-units workspace clean.
qwen3.6-35b-a3b-mtp-q6 Merged a cleanup change that switches test file generation from the current working directory to pytest's tmp_path fixture. This isolates test artifacts and prevents repository clutter when running make test-units.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#118 tests: use tmp_path instead of mock_path rockcraft merged Merged a unit test fix replacing mock_path with tmp_path to resolve fixture scope issues. Approved by one reviewer, passed CI, and modified 1 file (+3/-3 lines).
73%
#896 test: don't leave behind test files rockcraft merged Merged a fix preventing OCI tests from leaving residual files in the project root. The change redirects test output to a temporary directory. Approved by three reviewers with all CI checks passing.
71%
#60 tests: move test data to a common location craft-archives merged Merged following reviewer approval and passing CI. Relocates test data to a common directory, resolving issue #39. Modifies 13 files with zero coverage impact.
70%