← Back to issue list

cleanup: don't write test files in cwd

View original Github issue

Metadata

Project
rockcraft
Number
#51
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #51 in commit 8e9145c1, switching unit tests to tmp_path so test files no longer pollute the working directory.

Resolution: closed resolved

Reason: The cleanup was merged through canonical/rockcraft#51 as commit 8e9145c1, using pytest's tmp_path fixture to isolate test data and keep make test-units output clean.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Use "tmp_path" to isolate test data and keep the result of "make test-units" clean. I want to do some more cleaning-up but I figured I'd get this 'easy' fix out of the way

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #51 in commit 8e9145c1, switching unit tests to tmp_path so test files no longer pollute the working directory.
stealth/space-bunny-alpha — closed resolved Merged PR #51: updated tests to use tmp_path instead of writing test files into the working directory, keeping make test-units output clean.
qwen/qwen3.6-35b-a3b — — Merged a cleanup fix that isolates test data using tmp_path instead of writing to the current working directory. This keeps make test-units output clean. Approved by one reviewer and changed one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged a cleanup change that redirects test file output to pytest's tmp_path fixture instead of the current working directory. This isolates test artifacts and keeps the make test-units workspace clean.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#684 Run tests from /tmp snapcraft merged Merged as commit c6db1cd3a, updating the test setup to run tests from /tmp.
73%
#896 test: don't leave behind test files rockcraft merged Merged PR #896 in commit 2cfd9f44, moving OCI test files to a temporary directory so tests no longer leave artifacts in the project root.
72%
#624 test: use `new_dir` fixture craft-parts merged Merged PR #624 as commit d214d9d8, updating two unit tests to use new_dir so test files no longer pollute the repository working directory.
71%