← Back to issue list

test: don't leave behind test files

View original Github issue

Metadata

Project
rockcraft
Number
#896
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #896 in commit 2cfd9f44, moving OCI test files to a temporary directory so tests no longer leave artifacts in the project root.

Resolution: closed resolved

Reason: The one-line test cleanup was approved and merged as commit 2cfd9f44. All reported CI checks passed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- One of the OCI tests was leaving behind test files in the main project directory after running. This PR just makes those test files live in a temp directory instead.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #896 in commit 2cfd9f44, moving OCI test files to a temporary directory so tests no longer leave artifacts in the project root.
stealth/space-bunny-alpha — closed resolved Merged PR #896 in commit 2cfd9f44, moving OCI test files to a temporary directory to prevent test artifacts in the project directory.
stealth/space-bunny-alpha — closed resolved Merged a one-line test fix to run OCI test files in a temporary directory, preventing test artifacts from being left in the project directory.
qwen/qwen3.6-35b-a3b — — Merged a fix preventing OCI tests from leaving residual files in the project root. The change redirects test output to a temporary directory. Approved by three reviewers with all CI checks passing.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for an OCI test that left files in the project root. The change redirects test output to a temporary directory, ensuring clean test runs and preventing file clutter.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#51 cleanup: don't write test files in cwd rockcraft merged Merged PR #51 in commit 8e9145c1, switching unit tests to tmp_path so test files no longer pollute the working directory.
72%
#2735 test: add regression test for issue #2361 charmcraft merged Merged PR #2735 as commit 8ef26978, adding regression coverage so artifacts are not moved when project and output directories are identical.
72%