← Back to issue list

test: don't leave behind test files

View original Github issue

Metadata

Project
rockcraft
Number
#896
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged a fix preventing OCI tests from leaving residual files in the project root. The change redirects test output to a temporary directory. Approved by three reviewers with all CI checks passing.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- One of the OCI tests was leaving behind test files in the main project directory after running. This PR just makes those test files live in a temp directory instead.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix preventing OCI tests from leaving residual files in the project root. The change redirects test output to a temporary directory. Approved by three reviewers with all CI checks passing.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for an OCI test that left files in the project root. The change redirects test output to a temporary directory, ensuring clean test runs and preventing file clutter.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that redirects an OCI test to write files to a temporary directory instead of the main project directory, preventing leftover test artifacts after execution.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#461 test: improve test coverage fetch-service merged Merged to improve test coverage, adding 270 lines across three files. Approved by two reviewers with all CI checks passing.
75%
#60 tests: move test data to a common location craft-archives merged Merged following reviewer approval and passing CI. Relocates test data to a common directory, resolving issue #39. Modifies 13 files with zero coverage impact.
74%
#458 test: improve test coverage fetch-service merged Merged after approval from two reviewers and passing CI checks. Added 370 lines of test code across five files to improve overall test coverage.
72%
#758 fix(testing): don't change the output artifact location craft-application merged Merged fix for #752 that keeps test output artifacts in the standard location instead of moving them to a spread subdirectory. Approved by reviewers and passed CI checks prior to merge.
72%
#3719 tests: fix lifecycle tests to run on new directory snapcraft merged Merged a fix for lifecycle tests to run in a new directory instead of the current one. Approved by a reviewer, passed CI, and changed three lines.
72%
#18 ci: ensure tests succeed in CI craft-application merged Merged updates to CI configuration ensuring tests pass successfully. Approved by one reviewer, modifying five files with 23 additions and 13 deletions.
72%
#986 fix(tests): don't fail if you have additional JREs craft-parts merged Merged a fix preventing test failures when additional JREs are installed. Approved by two reviewers, passed CI, and modified one file with two line changes. Resolves #985.
71%
#5375 test: fix command tests snapcraft merged Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
71%
#51 cleanup: don't write test files in cwd rockcraft merged Merged a cleanup fix that isolates test data using tmp_path instead of writing to the current working directory. This keeps make test-units output clean. Approved by one reviewer and changed one file.
71%
#367 Tests improvements to minimize future merges from resources draft branch charmcraft merged Merged test-only improvements to streamline future merges from a draft branch. Changes simplify OCIRegistry calls, improve naming, add auth schema, and isolate a main test. No functionality affected. Approved by two reviewers and passed CI.
71%