← Back to issue list

chore(lint): remove isort

View original Github issue

Metadata

Project
rockcraft
Number
#543
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a pull request replacing isort with Ruff for linting. The update modifies three files to utilize Ruff's capabilities, streamlining the configuration. Approved by two reviewers.

Suggested action:

No scores available.

Issue body

Ruff replaces isort - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a pull request replacing isort with Ruff for linting. The update modifies three files to utilize Ruff's capabilities, streamlining the configuration. Approved by two reviewers.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer PR to remove isort, replacing it with Ruff for unified linting. Accepted without comments and integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 Successfully merged, replacing isort with Ruff for import sorting. Maintainer lengau integrated the linting configuration update.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#715 chore(lint): use ruff from snap craft-parts merged Merged a linting chore switching to ruff from snap. Approved by two reviewers, the change modifies three files with a net reduction of two lines.
85%
#700 chore: update ruff craft-parts merged Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702.
84%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
83%
#22 chore(lint): update ruff and config starbase merged Merged ruff linter and configuration updates. Added an ignore rule for test functions with excessive arguments. Approved by one reviewer, modifying two files with a +4/-2 line change.
82%
#651 chore(linter): refine ruff configurations craft-parts merged Merged into main after passing CI and receiving two approvals. The change restores previously removed Pylint rules to the Ruff linter configuration, with one rule temporarily commented out pending upstream updates.
81%
#204 chore: use ruff snap starbase merged Merged "chore: use ruff snap". Approved by 3 reviewers and passed CI checks. Modified 4 files with a net diff of +5/-5 lines.
80%
#115 chore(deps): update ruff and fix linting issue craft-application merged Merged into main after two approvals and passing CI. The update refreshed the ruff dependency and resolved a linting issue across two files. Codecov recorded a negligible 0.10% coverage decrease upon merge.
80%
#103 chore: fix new lints from ruff 0.12 craft-grammar merged Merged after approval and passing CI checks. Updated pre-commit ruff to 0.12 and resolved newly introduced lint errors across four files. Changes were cherry-picked from canonical/starbase#409.
80%
#200 chore(deps): update ruff and its configuration craft-application merged Merged an update to ruff and its configuration. Approved by two reviewers with passing CI checks. The change modified one file with five additions and five deletions.
79%
#4417 chore(deps): update ruff to 0.1.1 and fix lint issues snapcraft merged Merged dependency update upgrading ruff to 0.1.1 and resolving linting errors across 19 files. Approved by two reviewers, passed CI, and increased coverage by 0.01%. A newer ruff version was released shortly after merge.
78%