← Back to issue list

chore(lint): remove isort

View original Github issue

Metadata

Project
rockcraft
Number
#543
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #543 in commit 041e3d23, removing isort and using Ruff's import-sorting checks to consolidate lint configuration.

Resolution: closed resolved

Reason: The change was approved by two reviewers and merged. Commit 041e3d23 removed standalone isort usage and configuration in favor of Ruff.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Ruff replaces isort - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #543 in commit 041e3d23, removing isort and using Ruff's import-sorting checks to consolidate lint configuration.
stealth/space-bunny-alpha — closed resolved Merged canonical/rockcraft#543, removing isort in favor of Ruff and updating three files to consolidate linting configuration.
qwen/qwen3.6-35b-a3b — — Merged a pull request replacing isort with Ruff for linting. The update modifies three files to utilize Ruff's capabilities, streamlining the configuration. Approved by two reviewers.
qwen3.6-35b-a3b-mtp-q6 — — Merged a maintainer PR to remove isort, replacing it with Ruff for unified linting. Accepted without comments and integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1215 chore: linting rockcraft merged Merged in #1215 (commit 927ce1e4), replacing an unnecessary str() call in a test fixture with a string literal to satisfy Ruff UP018.
76%
#36 chore: switch to ruff craft-platforms merged Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files.
75%
#375 chore(lint): Remove trailing whitespace rockcraft merged Merged PR #375 removed trailing whitespace from one file (+4/-4), resolving yamllint complaints; landed as commit 777df7e3.
72%
#103 chore: fix new lints from ruff 0.12 craft-grammar merged Merged PR #103 as a3ef1dd, updating Ruff to 0.12 and fixing resulting lint errors across four files; cherry-picked from canonical/starbase#409.
72%