chore: fix new lints from ruff 0.12
Metadata
Current evaluation
Merged PR #103 as a3ef1dd, updating Ruff to 0.12 and fixing resulting lint errors across four files; cherry-picked from canonical/starbase#409.
Resolution: closed resolved
Reason: PR #103 was merged as commit a3ef1dd with all CI checks passing. It fixed the Ruff 0.12 lint failures by applying the upstream canonical/starbase#409 changes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
Bumps the precommit ruff and fixes lint errors introduced by ruff 0.12. Cherry-picks https://github.com/canonical/starbase/pull/409
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #103 as a3ef1dd, updating Ruff to 0.12 and fixing resulting lint errors across four files; cherry-picked from canonical/starbase#409. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #103 as a3ef1dd, bumping pre-commit Ruff to 0.12 and fixing resulting lint errors in four files. The change was cherry-picked from canonical/starbase#409. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #103 as a3ef1dd, updating pre-commit Ruff to 0.12 and fixing new lint errors across four files; changes were cherry-picked from canonical/starbase#409. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-grammar#103, updating pre-commit Ruff to 0.12 and fixing new lint errors across four files, cherry-picked from canonical/starbase#409. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI checks. Updated pre-commit ruff to 0.12 and resolved newly introduced lint errors across four files. Changes were cherry-picked from canonical/starbase#409. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/starbase#409
(confidence 100%)
Upstream Ruff 0.12 lint update explicitly cherry-picked into PR #103.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #588 chore: use the latest ruff config from starbase | craft-application | merged | Merged PR #588 as commit 44b1a940, adopting starbase's latest Ruff configuration and updating linting across 86 files for the Starflow migration. | |
| #22 chore(lint): update ruff and config | starbase | merged | Merged in canonical/starbase#22 via commit f3d35a6, updating Ruff and its config to ignore excessive test-function arguments (PLR0913). | |
| #36 chore: switch to ruff | craft-platforms | merged | Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files. | |
| #700 chore: update ruff | craft-parts | merged | Merged PR #700 updated Ruff configuration across four files, superseding #699; a follow-up lint issue was fixed in merged PR #702. | |
| #566 chore(deps): update dependency lint/ruff to v0.4.3 | craft-providers | merged | Renovate PR #566 bumped the lint/ruff pin from ==0.4.2 to ==0.4.3 (+1/-1 line). Approved by @mr-cal (who noted ruff would move to a snap at the next Starbase merge) and merged as commit e7b2ddc. | |
| #1347 chore(deps): update ruff and fix new linting errors | charmcraft | merged | Ruff pre-commit hook was bumped and resulting lint errors auto-fixed across 10 files (+40/-37). PR #1347 was merged by lengau on 2023-10-23 as commit 34018724. | |
| #581 chore(linter): ruff auto fix base on starbase config | craft-parts | merged | Merged Ruff autofixes across 156 files to align craft-parts with Starbase's lint configuration; change landed as commit 30b73d97. | |
| #115 chore(deps): update ruff and fix linting issue | craft-application | merged | Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking. | |
| #357 style: fix lints from ruff 0.12 | craft-cli | merged | Merged as dd635c9, fixing new Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed. | |
| #119 chore(deps): update dependency lint/ruff to v0.0.284 | starbase | merged | Renovate dependency bump PR #119 (lint/ruff 0.0.272 -> 0.0.284 in the ruff pre-commit hook) was approved and merged into main as commit be3ae62; +1/-1 line, no source changes. |