← Back to issue list

chore: fix new lints from ruff 0.12

View original Github issue

Metadata

Project
craft-grammar
Number
#103
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI checks. Updated pre-commit ruff to 0.12 and resolved newly introduced lint errors across four files. Changes were cherry-picked from canonical/starbase#409.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Bumps the precommit ruff and fixes lint errors introduced by ruff 0.12. Cherry-picks https://github.com/canonical/starbase/pull/409

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and passing CI checks. Updated pre-commit ruff to 0.12 and resolved newly introduced lint errors across four files. Changes were cherry-picked from canonical/starbase#409.
qwen3.6-35b-a3b-mtp-q6 Merged to update pre-commit ruff to 0.12 and fix resulting lint errors. Changes were cherry-picked from canonical/starbase#409.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
87%
#700 chore: update ruff craft-parts merged Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702.
85%
#115 chore(deps): update ruff and fix linting issue craft-application merged Merged into main after two approvals and passing CI. The update refreshed the ruff dependency and resolved a linting issue across two files. Codecov recorded a negligible 0.10% coverage decrease upon merge.
84%
#581 chore(linter): ruff auto fix base on starbase config craft-parts merged Merged automated ruff fixes applying the starbase config across 156 files. Adjusts formatting and import order, with tweaks for trailing commas and ignored rules. Approved by three reviewers and depends on PR #580.
83%
#4417 chore(deps): update ruff to 0.1.1 and fix lint issues snapcraft merged Merged dependency update upgrading ruff to 0.1.1 and resolving linting errors across 19 files. Approved by two reviewers, passed CI, and increased coverage by 0.01%. A newer ruff version was released shortly after merge.
82%
#580 chore(linter): enable ruff base on starbase config craft-parts merged Merged a chore enabling the ruff linter based on the starbase configuration. Approved by two reviewers, the update modified six files with 224 additions and 134 deletions.
82%
#155 chore(deps): update dependency lint/ruff to v0.1.15 craft-store merged Automatically updated lint/ruff from v0.1.9 to v0.1.15 via Renovate bot. The PR passed CI checks, received two approvals, and was successfully merged.
82%
#214 chore(deps): update dependency lint/ruff to v0.1.7 craft-cli merged Merged an automated dependency update upgrading lint/ruff from v0.1.6 to v0.1.7. Approved by two reviewers, passed CI checks, maintained 94.77% test coverage, and modified a single file before final merge.
81%
#165 chore(deps): update dependency lint/ruff to v0.1.7 craft-application merged Merged an automated dependency update for lint/ruff from v0.1.6 to v0.1.7. Approved by two reviewers, passed CI checks, and successfully integrated into the main branch.
81%
#91 chore(deps): update dependency lint/ruff to v0.0.272 starbase merged Merged automated dependency update for lint/ruff from v0.0.269 to v0.0.272. Approved by a reviewer, passed CI checks, and merged without coverage changes.
81%