fix: delay enabling the overlay feature
Metadata
Current evaluation
Merged PR #592 in commit 7d5df56b delayed overlay-feature enablement until Project construction and fixed #585.
Resolution: closed resolved
Reason: PR #592 was merged with commit 7d5df56b, moving overlay-feature setup out of module import and into Project creation. The PR explicitly fixes #585.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Previously, the craft-parts Feature creation was happening as soon as the lifecycle_service module was imported (as top-level code). This was an erroneous attempt to address the fact that the feature has to be enabled by the time the Application loads the project *but also* in tests.
Instead, just enable the feature when creating the Project object, regardless of "origin". This way we can ensure the Project itself is doing the right thing, without special test setup that might not reflect production "reality".
Fixes #585
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #592 in commit 7d5df56b delayed overlay-feature enablement until Project construction and fixed #585. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged maintainer PR delayed overlay-feature enablement until Project construction, fixing #585 and replacing test-specific setup. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged fix delayed overlay enablement until Project creation, removing import-time initialization and test-specific setup. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR delayed overlay-feature enablement from lifecycle_service import time to Project creation, resolving the premature initialization problem described in #585. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for #585 that delays overlay feature enablement from module import to Project object creation. Approved by two reviewers, passed CI, and updated six files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix delaying overlay feature enablement from module import to Project instantiation. This ensures consistent behavior across production and tests without special setup, resolving issue #585. |
Update history
No update history recorded yet.
Related work
-
Related To:
rockcraft#585
(confidence 100%)
The PR body explicitly identifies #585 as the issue it fixes.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #667 fix: make overlay and partition features mutually exclusive | craft-parts | merged | Merged PR #667 as commit 6582b829, making overlay and partitions mutually exclusive and fixing #632. | |
| #1190 fix(overlay): detect conflicts between overlay and install | craft-parts | merged | Merged PR #1190 fixed Stage collision detection by including overlay layer contents and added integration tests for colliding and non-colliding scenarios in commit b7455277. |