fix: make overlay and partition features mutually exclusive
Metadata
Current evaluation
Merged a fix enforcing mutual exclusivity between overlay and partitions features, as they are orthogonal. Approved by two reviewers, passed CI, and resolves issue #632.
Suggested action: —
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Make `overlay` and `partitions` mutually exclusive features.
This is a "fix" because they are orthogonal and were never intended to be used together.
If an application ever needs both features, we will have to start with a spec.
Fixes #632
(CRAFT-2415)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix enforcing mutual exclusivity between overlay and partitions features, as they are orthogonal. Approved by two reviewers, passed CI, and resolves issue #632. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix enforcing mutual exclusivity between overlay and partitions features, as they are orthogonal and never intended to coexist. Resolves #632. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1035 feat: reconcile overlays and partition features | craft-parts | merged | Merged. Implements simultaneous overlay and partition feature support, resolving issue #1028. Approved by three reviewers with passing CI. Further tests and refactoring will follow in a subsequent PR. | |
| #632 Make partitions and overlay features mutually exclusive | craft-parts | closed | Implemented mutual exclusivity between partitions and overlays to prevent undefined behavior. The task was closed after the restriction was added to the codebase. | |
| #1541 fix(organize): make organizing to the overlay idempotent | craft-parts | merged | Merged to fix overlay organization idempotency and resolve #1488. Copilot automatically resolved merge conflicts in commit 4282caa6, reverting BUILD_PARTITION while preserving OVERLAY_PARTITION logic. All tests pass. | |
| #1193 feat: exclude files already distributed to another partition | craft-parts | merged | Merged a change simplifying exclusion of already migrated files during overlay migration by recording subpaths instead of tracking whiteout files. Approved by two reviewers, passed all CI checks, and resolves issue #1173. | |
| #1190 fix(overlay): detect conflicts between overlay and install | craft-parts | merged | Merged fix enhancing Stage step collision detection to account for overlay contents, preventing conflicts with install directories. Includes integration tests, passed all CI checks, and received approval from three reviewers. | |
| #602 fix: enable overlays in _enable_craft_parts_features() | rockcraft | merged | Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated. | |
| #1123 fix: Prime content from overlay when split into partitions | craft-parts | merged | Merged fix for priming overlay content when split into partitions. Replaces direct overlay reliance with stage directory and migration state. Approved by three reviewers, passed all CI checks, and resolves issue #1127. | |
| #652 feat(partitions): clean partition directories | craft-parts | merged | Merged changes cleaning partition directories when the partitions feature is enabled. Approved by two reviewers, passed CI, and resolves issue #634. |