← Back to issue list

Fix docs build languange tests

View original Github issue

Metadata

Project
rockcraft
Number
#642
Type
pull request
State
merged
Author
clay-lake
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/rockcraft#642 as commit 8042e14b, updating docs woke tests to use the canonical configuration, handle ignore files, and fail on language violations.

Resolution: closed resolved

Reason: The pull request was approved and merged as commit 8042e14b. Its docs/Makefile changes made the language check use the canonical woke configuration, account for ignore files, and exit unsuccessfully when violations are found.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR includes several fixes for the language tests in our docs/Makefile: - Fixed woke utility skipping .*ignore files. This appears to be a bug in the utility. I'll raise this issue with the maintainer. - Disabled default woke configuration and exclusively test ours in canonical/Inclusive-naming. - Enabled error exit status. The Tests action will now show if there are language issues. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#642 as commit 8042e14b, updating docs woke tests to use the canonical configuration, handle ignore files, and fail on language violations.
stealth/space-bunny-alpha — closed resolved Merged #642 in commit 8042e14b, updating docs language tests to use the canonical woke config, handle ignore files, and fail when language violations are found.
stealth/space-bunny-alpha — closed resolved PR #642 merged as commit 8042e14b ("chore: update woke config"): docs/Makefile language tests now use only the canonical woke config, handle .*ignore files, and exit non-zero on language violations.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#642, commit 8042e14b: docs language tests now use the canonical configuration, handle ignore files, and fail on language violations.
qwen/qwen3.6-35b-a3b — — Merged after approval. Updated docs/Makefile to fix language tests by correcting the woke utility's ignore file handling, disabling default config, and enabling error exit status. CI passed. Subsequent comments referenced unrelated spread test failures.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Resolved docs build language test failures by patching a woke utility bug that skipped ignore files, disabling the default configuration, and enabling error exit status for accurate CI reporting.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#643 (confidence 100%)

    Closed unmerged test PR used to demonstrate the language-test failure; it was not the fix.

Related issues

Issue Project State Summary Similarity
#400 fix(docs): make sure we can build the example rockcraft.yaml rockcraft merged Merged in e7e3091e: corrected the documented example to use armhf and added a spread test verifying that rockcraft.yaml builds.
72%
#647 Test build to check fix for failing docs tests rockcraft closed Test-build PR closed unmerged; its OpenSSL slice tutorial fix landed via merged canonical/rockcraft#648 in commit 62593398.
71%