← Back to issue list

fix(docs): make sure we can build the example rockcraft.yaml

View original Github issue

Metadata

Project
rockcraft
Number
#400
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged in e7e3091e: corrected the documented example to use armhf and added a spread test verifying that rockcraft.yaml builds.

Resolution: closed resolved

Reason: PR canonical/rockcraft#400 was approved and merged as commit e7e3091e, resolving #399 and preventing regressions through a build test for the documented example.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Put the example code in a spread test, to ensure that we can always build the example we give in the docs. Fixes #399 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in e7e3091e: corrected the documented example to use armhf and added a spread test verifying that rockcraft.yaml builds.
stealth/space-bunny-alpha — closed resolved Merged in e7e3091e: corrected the documented rockcraft.yaml example to use armhf and added a spread test to verify it builds, fixing canonical/rockcraft#399.
stealth/space-bunny-alpha — closed resolved Fixed the rockcraft.yaml docs example by changing arm to armhf and adding spread coverage. Merged as e7e3091e, closing #399.
stealth/space-bunny-alpha — closed resolved Merged as canonical/rockcraft#400 (commit e7e3091e), fixing #399 by adding a spread test and correcting the documented rockcraft.yaml example so it builds successfully.
qwen/qwen3.6-35b-a3b — — Merged to resolve issue #399. Added a spread test validating the example rockcraft.yaml build process for documentation. Approved by three reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix adding a spread test to verify building the example rockcraft.yaml from the documentation, resolving issue #399. The change ensures the documented example remains buildable.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#399 (confidence 100%)

    The PR explicitly states that it fixes #399, the incorrect arm key in the documented example.

Related issues

Issue Project State Summary Similarity
#399 rockcraft.yaml example contains `arm` key instead of `armhf` rockcraft closed Fixed in canonical/rockcraft#400 (e7e3091e): corrected the documentation example from arm to armhf and added a spread test to verify it builds.
83%
#289 docs: expand rockcraft.yaml reference rockcraft merged Merged into main via commit 654c9c01, reorganizing reference docs and expanding the rockcraft.yaml configuration reference across seven files.
75%
#682 docs: fix typo rockcraft merged Merged rockcraft#682 (commit 371bc723) fixing a one-line documentation typo; approved by 3 reviewers, CLA signed, merged.
73%
#406 fix(docs): drop "--edge" from rockcraft install instructions rockcraft merged Merged PR #406, commit 85094038, removed obsolete "--edge" from Rockcraft installation instructions in five documentation files, fixing #404.
72%
#642 Fix docs build languange tests rockcraft merged Merged in canonical/rockcraft#642 as commit 8042e14b, updating docs woke tests to use the canonical configuration, handle ignore files, and fail on language violations.
72%
#1082 fix: reference slug path in for rockcraft.yaml #2 rockcraft merged Merged in canonical/rockcraft#1082 via commit cae91c7d, correcting the CLI’s rockcraft.yaml reference link to the documentation slug rockcraft-yaml.
71%
#8 project: add rockcraft.yaml load function (CRAFT-586) rockcraft merged Merged PR #8 added a dedicated rockcraft.yaml loader with tests; merge commit 3cf2d6fa contains implementation commit 85981d00.
71%
#1056 docs: clean up 'rockcraft.yaml' rockcraft merged Merged PR #1056 as commit 32d800b9, upgrading pydantic-kitbash to v0.1.1 and cleaning rockcraft.yaml docs by removing redundant modules and normalizing field order.
71%
#310 docs: fix url of rockcraft format rockcraft merged Merged in canonical/rockcraft#310 via commit 8145238e, correcting the Rockcraft format URL and resolving the convert-to-pebble-layer.rst linkcheck failure.
70%