← Back to issue list

fix(docs): make sure we can build the example rockcraft.yaml

View original Github issue

Metadata

Project
rockcraft
Number
#400
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged to resolve issue #399. Added a spread test validating the example rockcraft.yaml build process for documentation. Approved by three reviewers and passed all CI checks.

Suggested action:

No scores available.

Issue body

Put the example code in a spread test, to ensure that we can always build the example we give in the docs. Fixes #399 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to resolve issue #399. Added a spread test validating the example rockcraft.yaml build process for documentation. Approved by three reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a fix adding a spread test to verify building the example rockcraft.yaml from the documentation, resolving issue #399. The change ensures the documented example remains buildable.
qwen3.6-35b-a3b-mtp-q6 Merged a fix adding a spread test to verify the example rockcraft.yaml in the documentation builds correctly, resolving issue #399.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#406 fix(docs): drop "--edge" from rockcraft install instructions rockcraft merged Merged a documentation fix removing the "--edge" flag from rockcraft installation instructions, resolving issue #404. Approved by three reviewers, passed CI, and updated five files.
79%
#289 docs: expand rockcraft.yaml reference rockcraft merged Merged after three reviewers approved, the PR reorganized the documentation reference section and expanded the rockcraft.yaml reference guide, modifying 7 files.
78%
#323 docs: Add explanation on the Hello-world tutorial rockcraft merged Merged documentation update explaining the rockcraft.yaml file in the Hello World tutorial. Approved by three reviewers, the change adds 26 lines and removes 9 across two files.
76%
#174 tests: check before handling rockcraft instances rockcraft merged Merged a fix wrapping rockcraft LXC instance cleanup in an if condition to prevent errors when spread tests do not create instances. Approved by two reviewers, passed CI, and modified one file.
76%
#100 tests: print rockcraft log files on spread failure rockcraft merged Merged: adds 11 lines to print rockcraft log files during spread test failures, improving debugging visibility. Approved by one reviewer and passed CI checks.
76%
#1056 docs: clean up 'rockcraft.yaml' rockcraft merged Merged documentation cleanup for rockcraft.yaml. Updates include upgrading pydantic-kitbash to v0.1.1, removing unnecessary module declarations, and normalizing field order. Approved by two reviewers and merged despite unrelated snap-test failures.
76%
#6 project: add basic rockcraft.yaml parsing and validation (CRAFT-584) rockcraft merged Merged changes adding rockcraft.yaml parsing and validation to halt builds on invalid parts. Renamed the tag field to version and updated the output image suffix to .rock. Approved and passed CI across seven files.
76%
#1304 test(spread): fix cross-test contamination rockcraft merged Merged fix for spread test cross-contamination. Resolved by copying a clean rockcraft.yaml template at test start to isolate variants. Approved by two reviewers and passed CI checks.
75%
#150 docs: add contributing file rockcraft merged Merged Rockcraft contribution guidelines. Added 17 lines to one file, approved by one reviewer, and completed with zero unresolved comments or CI failures.
74%
#1082 fix: reference slug path in for rockcraft.yaml #2 rockcraft merged Merged a one-line fix correcting an incorrect documentation URL in CLI error messages. The change updates the reference path in rockcraft.yaml error prompts to the proper slug path. CI checks passed and reviewers approved before merging.
74%