← Back to issue list

parts: use part validator from craft-parts

View original Github issue

Metadata

Project
rockcraft
Number
#70
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #70 as 3daa2224: rockcraft now uses craft-parts' shared part validator (from craft-parts#277 / 67022699) instead of its own local implementation, dropping the duplicate code.

Resolution: closed resolved

Reason: The pull request was approved and merged into main as commit 3daa2224 ("parts: use part validator from craft-parts (#70)"), replacing rockcraft's local part/plugin validation with the common validator added upstream in craft-parts PR #277 (commit 67022699, resolving craft-parts#176). The same adoption later happened in snapcraft PR #3909.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Use the common part validator implemented in craft-parts to validate part data against part and plugin models, and drop the local implementation. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #70 as 3daa2224: rockcraft now uses craft-parts' shared part validator (from craft-parts#277 / 67022699) instead of its own local implementation, dropping the duplicate code.
stealth/space-bunny-alpha — closed resolved Merged as 3daa2224; Rockcraft now delegates part and plugin data validation to craft-parts and removes its local validator.
stealth/space-bunny-alpha — closed resolved PR #70 merged as commit 3daa2224: rockcraft now calls craft-parts' shared validate_part() (added in craft-parts 67022699 / PR #277) and drops its own local part validator.
stealth/space-bunny-alpha — closed resolved Merged PR #70 as 3daa2224, adopting craft-parts' common validator for part and plugin data and removing rockcraft's local implementation.
qwen/qwen3.6-35b-a3b — — Merged after approval and rebase. Replaced the local part validator with the shared implementation from craft-parts to validate part data against part and plugin models, removing the deprecated local code.
qwen3.6-35b-a3b-mtp-q6 — — Merged after rebasing on main. Replaced the local part validator with the shared craft-parts implementation to validate part data against part and plugin models, eliminating redundant local code.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#277 (confidence 92%)

    Upstream PR that added the shared part/plugin validator in craft-parts (merged as 67022699), which this rockcraft PR consumes.

  • Duplicate Of: canonical/snapcraft#3909 (confidence 80%)

    Snapcraft made the identical change later, adopting the same craft-parts validator and dropping its local implementation.

  • Related To: canonical/craft-parts#176 (confidence 78%)

    Issue requesting a craft-parts validation helper, satisfied by craft-parts#277.

Related issues

Issue Project State Summary Similarity
#3909 parts: use part validator from craft-parts snapcraft merged Merged PR #3909 (commit 8ae29b79e) replaced snapcraft's local part validator with craft_parts.validate_part in snapcraft/parts/__init__.py, dropping the local implementation (+7/-119 across 6 files).
81%
#3636 parts: integrate craft-parts (CRAFT-765) snapcraft merged Merged as ae8467056, integrating craft-parts for project-part validation and parts lifecycle processing (CRAFT-765).
76%
#176 Craft-parts should provide a part validation helper craft-parts closed Shared part validation was added by craft-parts PR #277, merged as commit 67022699; Snapcraft later adopted it in canonical/snapcraft#3909.
75%
#3 parts: add parts support (CRAFT-27) rockcraft merged Merged PR #3 added initial Craft Parts processing support to Rockcraft (CRAFT-27) via implementation commit 912f7472 and merge commit c0544b17.
75%
#277 parts: add part validator craft-parts merged Merged in #277 as commit 67022699, adding shared part and plugin model validation to the library and resolving #176.
72%
#483 docs: make the part properties reference reusable craft-parts merged Merged PR #483 (commit 8df03154) made the part properties reference reusable for CRAFT-1713 and a corresponding Rockcraft change.
71%
#308 docs: imported the part properties reference from Craft Parts rockcraft merged Imported Craft Parts' part-properties reference into Rockcraft docs; PR #308 merged as 13bf8368 after upstream craft-parts#483 and #486 enabled and corrected the reusable documentation.
71%