← Back to issue list

parts: use part validator from craft-parts

View original Github issue

Metadata

Project
rockcraft
Number
#70
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and rebase. Replaced the local part validator with the shared implementation from craft-parts to validate part data against part and plugin models, removing the deprecated local code.

Suggested action:

No scores available.

Issue body

Use the common part validator implemented in craft-parts to validate part data against part and plugin models, and drop the local implementation. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and rebase. Replaced the local part validator with the shared implementation from craft-parts to validate part data against part and plugin models, removing the deprecated local code.
qwen3.6-35b-a3b-mtp-q6 Merged after rebasing on main. Replaced the local part validator with the shared craft-parts implementation to validate part data against part and plugin models, eliminating redundant local code.
qwen3.6-35b-a3b-mtp-q6 Merged by cmatsuoka. Replaced the local part validator with craft-parts shared implementation to validate part data against part and plugin models. Rebased on main prior to merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3909 parts: use part validator from craft-parts snapcraft merged Merged into main. Replaced the local part validator with the shared craft-parts implementation, removing 119 lines across six files. Approved by reviewers, passed CI, and increased test coverage by 0.80%.
91%
#277 parts: add part validator craft-parts merged Merged adds a centralized part validation helper that validates data against part and plugin models, replacing per-tool logic. Approved, passed CI, and resolves issue #176.
84%
#3636 parts: integrate craft-parts (CRAFT-765) snapcraft merged Merged after reviewer approval and passing CI checks. Integrates craft-parts for part validation and lifecycle processing. Modifies 12 files, adding 369 lines and removing 20, fulfilling CRAFT-765.
78%
#176 Craft-parts should provide a part validation helper craft-parts closed Request to add a shared part validation helper to craft-parts was closed without implementation. No resolution or merge occurred, indicating the feature was abandoned.
76%
#93 lifecycle: add part validator (CRAFT-367) craft-parts closed Superseded without merging. The validator was simplified and moved to the application layer instead of being added to craft-parts.
74%
#294 docs: import Craft Parts documentation fragments rockcraft merged Merged after two reviewers approved and requested rebasing to sync with main. The change imports Craft Parts documentation fragments. CI passed, and preview confirms successful integration pending a Craft Parts release.
71%