parts: use part validator from craft-parts
Metadata
Current evaluation
Merged into main. Replaced the local part validator with the shared craft-parts implementation, removing 119 lines across six files. Approved by reviewers, passed CI, and increased test coverage by 0.80%.
Suggested action: —
No scores available.
Issue body
Use the common part validator implemented in craft-parts to validate part data against part and plugin models, and drop the local implementation.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Replaced the local part validator with the shared craft-parts implementation, removing 119 lines across six files. Approved by reviewers, passed CI, and increased test coverage by 0.80%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Replaced the local part validator with the shared implementation from craft-parts to validate part data against part and plugin models, removing the deprecated local code. Test coverage increased by 0.80%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Replaced the local part validator with the shared craft-parts implementation to validate part and plugin models. The change improved overall test coverage by 0.80 percent. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #70 parts: use part validator from craft-parts | rockcraft | merged | Merged after approval and rebase. Replaced the local part validator with the shared implementation from craft-parts to validate part data against part and plugin models, removing the deprecated local code. | |
| #3636 parts: integrate craft-parts (CRAFT-765) | snapcraft | merged | Merged after reviewer approval and passing CI checks. Integrates craft-parts for part validation and lifecycle processing. Modifies 12 files, adding 369 lines and removing 20, fulfilling CRAFT-765. | |
| #277 parts: add part validator | craft-parts | merged | Merged adds a centralized part validation helper that validates data against part and plugin models, replacing per-tool logic. Approved, passed CI, and resolves issue #176. | |
| #4635 feat(docs): pull in content from craft-parts | snapcraft | merged | Merged documentation update pulling content from craft-parts. Approved by three reviewers, passed CI, and achieved full test coverage on modified lines. The change modified 21 files with 123 additions and 5 deletions. | |
| #191 requirements: update craft-parts to 1.18.1 | rockcraft | merged | Merged update to craft-parts 1.18.1, fixing ignored file patterns during local source processing. Approved by two reviewers with passing CI checks. Modified three files. | |
| #4027 requirements: update craft-parts to 1.18.1 | snapcraft | merged | Merged update to craft-parts 1.18.1, fixing ignored file patterns during local source processing. Approved by reviewer, passed CI, rebased on main, and merged without coverage changes. | |
| #294 docs: import Craft Parts documentation fragments | rockcraft | merged | Merged after two reviewers approved and requested rebasing to sync with main. The change imports Craft Parts documentation fragments. CI passed, and preview confirms successful integration pending a Craft Parts release. | |
| #3 parts: add parts support (CRAFT-27) | rockcraft | merged | Merged after approval. Integrates craft-parts to add initial parts processing support to Rockcraft. Changes span 11 files with 375 additions and 6 deletions. Zero unresolved comments and passing CI checks. | |
| #25 parts: add PartsLifecycle support | craft-application | merged | Merged into main following reviewer approval and passing CI. Adds PartsLifecycle support to the parts module, modifying 9 files with 100% test coverage. Addresses CRAFT-1752. | |
| #501 feat(docs): pull in content from craft-parts | rockcraft | merged | Merged documentation updates pulling content from craft-parts. Approved by two reviewers, the change modified 18 files with 103 additions and 17 deletions. |