← Back to issue list

tests: remove duplicated unit tests

View original Github issue

Metadata

Project
rockcraft
Number
#73
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #73 as commit 7ace0b2b, removing duplicate unit tests from test_provider.py and test_providers.py; the duplication originated in c7a49bac29.

Resolution: closed resolved

Reason: PR #73 was approved and merged as commit 7ace0b2b, deleting 76 lines of duplicate tests introduced by commit c7a49bac29.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- `test_provider.py` and `test_providers.py` had duplicated tests. This was an artifact of commit c7a49bac29, which combined the same tests from `test_lxd.py` and `test_multipass.py`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #73 as commit 7ace0b2b, removing duplicate unit tests from test_provider.py and test_providers.py; the duplication originated in c7a49bac29.
stealth/space-bunny-alpha — closed resolved Merged PR #73 as commit 7ace0b2b, removing 76 lines of duplicate provider unit tests introduced by commit c7a49bac29.
stealth/space-bunny-alpha — closed resolved Merged after approval, removing 76 lines of duplicate unit tests from test_provider.py and test_providers.py, an artifact introduced by commit c7a49bac29.
qwen/qwen3.6-35b-a3b — — Merged removal of duplicated unit tests from test_provider.py and test_providers.py, artifacts from a prior LXD and Multipass test consolidation. Approved, passed CI, and reduced two files by 60 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of duplicated unit tests from test_provider.py and test_providers.py. The duplication originated from a prior commit that combined test_lxd.py and test_multipass.py.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1928 tests: remove duplicate tests snapcraft merged PR #1928 by kyrofa merged (commit 74dc26774): removed duplicate unit tests, clarified test base class names, shaving time off unit test runtime.
74%
#130 fix(test): fix provider integration tests craft-application merged Merged into main as commit 1839647, correcting provider integration tests while retaining 100% diff coverage.
72%
#1266 tests: report coverage only in unit tests snapcraft merged Merged PR #1266 as commit 0c64f0b31, restricting coverage reporting to unit tests and incorporating reviewer feedback for Python 2/3 compatibility.
70%