← Back to issue list

tests: remove duplicate tests

View original Github issue

Metadata

Project
snapcraft
Number
#1928
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #1928 by kyrofa merged (commit 74dc26774): removed duplicate unit tests, clarified test base class names, shaving time off unit test runtime.

Resolution: closed resolved

Reason: The pull request itself was merged into the repository at commit 74dc26774, with +39/-30 lines across 8 test files removing duplicated tests and renaming test base classes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Also clarify names of test base classes so this mistake won't happen again. Should shave a few minutes off unit test time.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1928 by kyrofa merged (commit 74dc26774): removed duplicate unit tests, clarified test base class names, shaving time off unit test runtime.
stealth/space-bunny-alpha — closed resolved Merged #1928 in 74dc26774: removed duplicate tests and clarified test base-class names, reducing unit-test runtime.
qwen/qwen3.6-35b-a3b — — Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. This cleanup reduces overall unit test execution time.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#73 tests: remove duplicated unit tests rockcraft merged Merged PR #73 as commit 7ace0b2b, removing duplicate unit tests from test_provider.py and test_providers.py; the duplication originated in c7a49bac29.
74%