← Back to issue list

tests: remove duplicate tests

View original Github issue

Metadata

Project
snapcraft
Number
#1928
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Also clarify names of test base classes so this mistake won't happen again. Should shave a few minutes off unit test time.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.
qwen3.6-35b-a3b-mtp-q6 Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. This cleanup reduces overall unit test execution time.
qwen3.6-35b-a3b-mtp-q6 Merged removal of duplicate tests and clarification of test base class names to prevent recurrence and reduce unit test execution time.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#461 test: improve test coverage fetch-service merged Merged to improve test coverage, adding 270 lines across three files. Approved by two reviewers with all CI checks passing.
78%
#458 test: improve test coverage fetch-service merged Merged after approval from two reviewers and passing CI checks. Added 370 lines of test code across five files to improve overall test coverage.
77%
#73 tests: remove duplicated unit tests rockcraft merged Merged removal of duplicated unit tests from test_provider.py and test_providers.py, artifacts from a prior LXD and Multipass test consolidation. Approved, passed CI, and reduced two files by 60 lines.
76%
#5375 test: fix command tests snapcraft merged Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
76%
#278 tests: additional tests to improve coverage fetch-service merged Merged after two reviews and passing CI checks. Adds additional tests across ten files to improve code coverage, changing +386/-60 lines.
76%
#3305 unit tests: fix runtests.sh not filtering tests when passed a subdirectory snapcraft merged Merged a one-line fix correcting runtests.sh to properly filter tests when a subdirectory is passed. Previously, the script ran the entire suite. Approved by two reviewers, passed CI, and merged.
75%
#3029 tests: speed up clean command unit tests snapcraft merged Merged changes that optimize clean command unit tests by isolating the implementation from dependencies. Execution time dropped from ~90 seconds to 0.5 seconds. Approved by one reviewer and passed CI checks.
75%
#60 tests: move test data to a common location craft-archives merged Merged following reviewer approval and passing CI. Relocates test data to a common directory, resolving issue #39. Modifies 13 files with zero coverage impact.
74%
#1787 tests: move refresh to unit folder snapcraft merged Merged a fix moving a misplaced refresh test into the unit folder. The test was previously excluded from regular runs due to the new directory structure, causing false passes. Approved by one reviewer, passed CI, and merged.
74%
#4160 tests: remove arch_triplet from unit test snapcraft merged Merged a unit test fix removing remaining arch_triplet references. The change resolves file overlap from two prior PRs. Approved by one reviewer, passed CI, and deleted two lines from a single test file.
74%