← Back to issue list

feat: make requirements.txt for extensions optional

View original Github issue

Metadata

Project
rockcraft
Number
#744
Type
pull request
State
open
Author
toabctl
Labels
Created
Updated
Closed

Current evaluation

Makes requirements.txt optional for 12-factor extensions by supporting pyproject.toml as an alternative. Maintainer declined the specific approach (Dec 2024), but pyproject.toml support was later added via #1090, making this PR superseded. No CI, no activity in over a year.

Suggested action: close stale

Reason: The PR is 668 days old with last activity 381 days ago. Maintainer @tigarmo explicitly declined the approach on 2024-12-03 ('the decision at this moment is to keep the extensions as they are'), and the feature has since been implemented differently: commit 4087b095 (#1090) added pyproject.toml support to gunicorn.py, so the code now accepts either requirements.txt or pyproject.toml. The PR's specific diff is no longer applicable to the current codebase.

Impact: 40 Quick Win: 28.0 Staleness: 85 Complexity: 30 Confidence: 82

Issue body

There are multiple ways within python to declare dependencies (eg. via pyproject.toml, setup.py or setup.cfg). Requiring a requirements.txt file in a specific path doesn't work for a lot of projects out there so make the requirements.txt file optional.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 40
Quick Win: 28.0
Staleness: 85
Complexity: 30
Confidence: 82
close stale Makes requirements.txt optional for 12-factor extensions by supporting pyproject.toml as an alternative. Maintainer declined the specific approach (Dec 2024), but pyproject.toml support was later added via #1090, making this PR superseded. No CI, no activity in over a year.
qwen/qwen3.6-35b-a3b
Staleness: 75
Complexity: 15
Confidence: 85
close stale Makes the requirements.txt file optional for extensions to support modern dependency declarations. Maintainers declined the change citing design philosophy, and the PR has been inactive for nearly a year.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 15
Confidence: 90
close not mergeable PR makes requirements.txt optional for Python extensions to support modern dependency managers. Maintainers declined the change, citing design philosophy and preference for pinned dependencies. PR is inactive.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 15
Confidence: 95
close not mergeable PR proposes making requirements.txt optional for extensions to support modern Python dependency tools. Maintainers declined, citing design philosophy and preference for pinned dependencies in applications. Inactive since Dec 2024.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 20
Confidence: 90
close stale Proposes making requirements.txt optional for extensions to support modern dependency managers. Maintainers declined for now, citing design cohesion and dependency freezing, but noted the policy could change with sufficient user demand. Status: declined, awaiting user demand.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: rockcraft#1090 (confidence 78%)

    Commit 4087b095 'feat: extensions compatibility with upstream tutorials' introduced tomllib-based pyproject.toml parsing in gunicorn.py _requirements(), achieving the PR's goal of not requiring requirements.txt specifically.

Related issues

No related issues found above the similarity threshold.