providers: capture logs from instance
Metadata
Current evaluation
Merged as commit 1fe5b57b: refactored instance log capture to use craft-providers temporarily_pull_file() and moved the method into providers.py.
Resolution: closed resolved
Reason: PR #77 was approved and merged into the project as commit 1fe5b57b, implementing the CRAFT-1351 provider refactor.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Refactor `capture_logs_from_instance()`:
- Use new `craft-providers` call `temporarily_pull_file()`
- Move method to `rockcraft/providers/providers.py`
(CRAFT-1351)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 1fe5b57b: refactored instance log capture to use craft-providers temporarily_pull_file() and moved the method into providers.py. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #77 (commit 1fe5b57b), moving capture_logs_from_instance() to providers.py and using craft-providers temporarily_pull_file() for CRAFT-1351. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor moving capture_logs_from_instance() to rockcraft/providers/providers.py and updating it to use craft-providers temporarily_pull_file(). Approved, resolving CRAFT-1351 with a 63-line reduction across six files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring of capture_logs_from_instance() to utilize temporarily_pull_file() from craft-providers and relocate the method to rockcraft/providers/providers.py, addressing CRAFT-1351. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3935 providers: refactor `capture_logs_from_instance()` | snapcraft | merged | Merged PR #3935 as d0da7f83f, moving capture_logs_from_instance() to providers.py and adopting craft-providers temporarily_pull_file(). | |
| #3950 providers: capture logs with debug-level logging | snapcraft | merged | Merged PR #3950 (848d7c830), restoring provider logs to debug level so capture_logs_from_instance() saves them to the log file instead of emitting them at trace level. | |
| #893 (internal) Refactor capture_logs_from_instance to use new interface (CRAFT-1306). | charmcraft | merged | Merged #893, refactoring capture_logs_from_instance to use the new CRAFT-1306 interface; implementation commit 5db3467c was merged via 35ed820a. | |
| #87 feat: fetch logs from inside the build instance | craft-application | merged | Merged to main as commit 519c9aa3. ProviderService.instance() now pulls the managed log file from the build instance (new _capture_logs_from_instance) and appends it to the outer log. Fixes issue #59. |