providers: capture logs from instance
Metadata
Current evaluation
Merged a refactor moving capture_logs_from_instance() to rockcraft/providers/providers.py and updating it to use craft-providers temporarily_pull_file(). Approved, resolving CRAFT-1351 with a 63-line reduction across six files.
Suggested action: —
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Refactor `capture_logs_from_instance()`:
- Use new `craft-providers` call `temporarily_pull_file()`
- Move method to `rockcraft/providers/providers.py`
(CRAFT-1351)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor moving capture_logs_from_instance() to rockcraft/providers/providers.py and updating it to use craft-providers temporarily_pull_file(). Approved, resolving CRAFT-1351 with a 63-line reduction across six files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring of capture_logs_from_instance() to utilize temporarily_pull_file() from craft-providers and relocate the method to rockcraft/providers/providers.py, addressing CRAFT-1351. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring of capture_logs_from_instance() to use craft-providers temporarily_pull_file(). The method was moved to rockcraft/providers/providers.py, addressing CRAFT-1351. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3935 providers: refactor `capture_logs_from_instance()` | snapcraft | merged | Merged into main following approval and passing CI. Refactored capture_logs_from_instance() to use craft-providers temporarily_pull_file() and moved it to providers.py, trimming 28 lines and increasing coverage by 0.09%. | |
| #893 (internal) Refactor capture_logs_from_instance to use new interface (CRAFT-1306). | charmcraft | merged | Merged refactoring of capture_logs_from_instance to use a new interface per CRAFT-1306. Approved by one reviewer with no unresolved comments. The update modifies seven files, reducing 133 lines and adding 59. | |
| #12 providers: retrieve data from instance log file (CRAFT-589) | rockcraft | merged | Merged implementation to retrieve instance log data upon provider execution completion and append it to external logs. Uses craft-cli predictable naming and sets library logs to debug level. Approved, rebased on main, and merged. | |
| #79 cli: capture logs in logfile | rockcraft | merged | Merged implementation capturing rockcraft logs to a file when running in managed mode. Approved by reviewer, passed CI, and added six lines to one file. |