(internal) Refactor capture_logs_from_instance to use new interface (CRAFT-1306).
Metadata
Current evaluation
Merged #893, refactoring capture_logs_from_instance to use the new CRAFT-1306 interface; implementation commit 5db3467c was merged via 35ed820a.
Resolution: closed resolved
Reason: PR #893 was approved and merged. Commit 5db3467c contains the interface refactor and was integrated by merge commit 35ed820a.
Evaluated by: mr-cal-bot
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #893, refactoring capture_logs_from_instance to use the new CRAFT-1306 interface; implementation commit 5db3467c was merged via 35ed820a. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #893, refactoring capture_logs_from_instance to use the new interface for CRAFT-1306; approved with no unresolved review comments. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #893, refactoring capture_logs_from_instance to use the new interface for CRAFT-1306; approved with no unresolved comments. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring of capture_logs_from_instance to use a new interface per CRAFT-1306. Approved by one reviewer with no unresolved comments. The update modifies seven files, reducing 133 lines and adding 59. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged internal refactoring that updated capture_logs_from_instance to use a new interface, resolving CRAFT-1306. The change was merged without additional discussion. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3905 parts: minor refactoring in instance log capture | snapcraft | merged | Merged #3905 as bd71c7abc, moving instance log capture into a finally block so it runs once instead of invoking the function twice. | |
| #77 providers: capture logs from instance | rockcraft | merged | Merged as commit 1fe5b57b: refactored instance log capture to use craft-providers temporarily_pull_file() and moved the method into providers.py. | |
| #3935 providers: refactor `capture_logs_from_instance()` | snapcraft | merged | Merged PR #3935 as d0da7f83f, moving capture_logs_from_instance() to providers.py and adopting craft-providers temporarily_pull_file(). |