(internal) Refactor capture_logs_from_instance to use new interface (CRAFT-1306).
Metadata
Current evaluation
Merged refactoring of capture_logs_from_instance to use a new interface per CRAFT-1306. Approved by one reviewer with no unresolved comments. The update modifies seven files, reducing 133 lines and adding 59.
Suggested action: —
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring of capture_logs_from_instance to use a new interface per CRAFT-1306. Approved by one reviewer with no unresolved comments. The update modifies seven files, reducing 133 lines and adding 59. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged internal refactoring that updated capture_logs_from_instance to use a new interface, resolving CRAFT-1306. The change was merged without additional discussion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged an internal refactor of capture_logs_from_instance to adopt a new interface, resolving CRAFT-1306. Integrated directly without additional review comments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #77 providers: capture logs from instance | rockcraft | merged | Merged a refactor moving capture_logs_from_instance() to rockcraft/providers/providers.py and updating it to use craft-providers temporarily_pull_file(). Approved, resolving CRAFT-1351 with a 63-line reduction across six files. | |
| #3935 providers: refactor `capture_logs_from_instance()` | snapcraft | merged | Merged into main following approval and passing CI. Refactored capture_logs_from_instance() to use craft-providers temporarily_pull_file() and moved it to providers.py, trimming 28 lines and increasing coverage by 0.09%. | |
| #3905 parts: minor refactoring in instance log capture | snapcraft | merged | Merged minor refactoring that captures logs in a finally block instead of calling the function twice. Approved by reviewer, passed CI, and changed one file. | |
| #887 (internal) Refactor clean project to only get the instance name (CRAFT-1398). | charmcraft | merged | Merged an internal refactor updating the clean project command to retrieve only the instance name. Approved by one reviewer, the change modifies nine files with a net reduction of 16 lines. |