← Back to issue list

providers: use ProviderError from craft-providers

View original Github issue

Metadata

Project
rockcraft
Number
#86
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged adoption of ProviderError from craft-providers. Replaced custom error handling with centralized exceptions, added error catching, and included comprehensive tests. Approved and passed CI.

Suggested action:

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Use `ProviderError` from craft-providers.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged adoption of ProviderError from craft-providers. Replaced custom error handling with centralized exceptions, added error catching, and included comprehensive tests. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged update to use ProviderError from craft-providers. Implemented error handling with a catch block and added comprehensive test coverage.
qwen3.6-35b-a3b-mtp-q6 Adopted ProviderError from craft-providers for error handling. Merged with added error catching and comprehensive test coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3943 providers: use new craft-providers interface snapcraft merged Merged to main. Replaced internal Provider classes with the craft-providers interface and consolidated the providers module. Approved after passing CI and spread tests. Coverage dropped 0.15% with 100% diff coverage; unrelated test failure tracked in PR #3944.
78%
#4295 cli: catch craft-provider errors snapcraft merged Merged after approval, adding CLI error handling for craft-provider failures. Resolves #4262 and CRAFT-1898. Passed CI checks and achieved 100% diff coverage across two modified files.
74%
#120 providers: use new craft-providers interface rockcraft merged Merged after review and CI approval. Replaced custom Provider classes with the new craft-providers interface, relocated providers.py, and refactored 17 files. Reduced codebase by over 1200 lines, resolving CRAFT-1349.
74%
#504 providers: improve error handling (CRAFT-472) charmcraft merged Improved error handling for provider-generated exceptions by adding try/except blocks for LXD and Multipass, chaining exceptions, and adding test coverage. Merged after approval and passing CI checks.
74%
#899 providers: use new craft-providers interface charmcraft merged Merged after replacing internal Provider classes with the new craft-providers interface. Refactored by moving providers.py to the package root, removing 1253 lines across 17 files. Resolved CRAFT-1279.
73%
#3786 providers: update craft-providers snapcraft merged Merged to main. Updates the craft-providers dependency to version 1.3.1. The change passed lint, unit tests, and manual verification. Coverage remained unchanged, and the update received maintainer approval prior to merging.
72%
#4419 cli: catch craft-provider errors snapcraft merged Merged a cherry-picked bugfix to catch craft-provider errors in the CLI. Approved, passed CI, and integrated into the hotfix/7.5 branch after resolving initial dependencies.
70%