cli: catch craft-provider errors
Metadata
Current evaluation
Merged a cherry-picked bugfix to catch craft-provider errors in the CLI. Approved, passed CI, and integrated into the hotfix/7.5 branch after resolving initial dependencies.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Cherry-pick the bugfix in https://github.com/snapcore/snapcraft/pull/4295 onto `hotfix/7.5`
Related to #429
(CRAFT-2174)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a cherry-picked bugfix to catch craft-provider errors in the CLI. Approved, passed CI, and integrated into the hotfix/7.5 branch after resolving initial dependencies. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Cherry-picked bugfix #4295 and merged into hotfix/7.5 to catch craft-provider errors in the CLI, resolving issue #429. The change passed all checks with 100% test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cherry-pick of a bugfix to catch craft-provider errors onto the hotfix/7.5 branch. Resolves CRAFT-2174 and issue #429. Briefly blocked by PR #4420 before merging. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4295 cli: catch craft-provider errors | snapcraft | merged | Merged after approval, adding CLI error handling for craft-provider failures. Resolves #4262 and CRAFT-1898. Passed CI checks and achieved 100% diff coverage across two modified files. | |
| #5878 build(hotfix/8.13): update craft-providers | snapcraft | merged | Merged to hotfix/8.13. Cherry-picked commit updates craft-providers, resolving the devel build-base EOL data warning. Approved by two reviewers and passed CI checks. | |
| #4421 build(deps): bump craft-providers to 1.19.1 | snapcraft | merged | Merged into hotfix/7.5 following approval and passing CI. Bumps craft-providers to 1.19.1, incorporates devel base tests, and resolves multipass test failures. Addresses issues #4412 and CRAFT-2171. | |
| #4429 build(deps): bump craft-providers to 1.19.1 (#4421) | snapcraft | merged | Merged bump of craft-providers to 1.19.1. Added spread tests for base: devel and fixed multipass spread tests. Approved with passing CI. Changes were also merged into the hotfix/7.5 branch. Coverage unchanged. | |
| #4671 build(deps): bump craft-providers to 1.23.1 | snapcraft | closed | Closed and superseded by PR #4673. The craft-providers dependency bump was approved and passed coverage checks but was redirected to the hotfix branch for release. | |
| #3682 cli: fix help command legacy fallback | snapcraft | merged | Merged fix for the CLI help command legacy fallback. Handles craft-cli's ProvideHelpException to standardize help output. Approved, passed CI, and achieved 100% diff coverage before merging into the 7.0 branch. | |
| #4192 requirements: bump craft-providers | snapcraft | merged | Bumped craft-providers dependency. PR approved, passed CI, and merged into main. Unrelated test failures were deferred to separate PRs. | |
| #2483 cli: Handle legitimate provider exec errors | snapcraft | merged | Merged CLI update that handles legitimate provider execution errors without raising exceptions. Resolves SNAPCRAFT-FK, SNAPCRAFT-EF, and SNAPCRAFT-E5. Approved by reviewer and merged with 123 additions and 13 deletions across nine files. | |
| #86 providers: use ProviderError from craft-providers | rockcraft | merged | Merged adoption of ProviderError from craft-providers. Replaced custom error handling with centralized exceptions, added error catching, and included comprehensive tests. Approved and passed CI. |