← Back to issue list

Feat: Add base-files and unit tests

View original Github issue

Metadata

Project
rockcraft
Number
#888
Type
pull request
State
closed
Author
alithethird
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged: the approved base-files change never landed after snap-tests and lint/files failed; no resolving or superseding PR or commit was identified.

Resolution: closed stale

Reason: PR #888 remained unmerged with failing snap-tests and lint/files checks and had no later activity, merge commit, replacement, or explanatory closing comment.

Evaluated by: mr-cal-bot

No scores available.

Issue body

12-Factor workloads may expect the standard linux files to be there so we are adding the `base-files` slice when the base is `bare` to create these folders. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed unmerged: the approved base-files change never landed after snap-tests and lint/files failed; no resolving or superseding PR or commit was identified.
stealth/space-bunny-alpha — closed stale PR #888 proposed adding base-files to bare bases and unit tests, but was closed unmerged after snap-tests and lint / files failures.
stealth/space-bunny-alpha — closed stale Closed unmerged after approval; snap-tests and lint/files failed. No resolving commit or replacement PR was identified.
stealth/space-bunny-alpha — closed stale Approved base-files and unit-test changes for bare bases were closed unmerged after snap-tests and lint / files failures; no resolving commit or replacement is identified.
stealth/space-bunny-alpha — closed stale Approved PR #888 was closed unmerged: its base-files slice and unit tests never landed, with snap-tests and lint / files still failing.
stealth/space-bunny-alpha — closed stale Closed unmerged: PR #888 added a base-files slice and unit tests for bare bases, but snap-tests and lint / files remained failing despite approval.
qwen/qwen3.6-35b-a3b — — Changes adding base-files and unit tests were approved but closed without merging due to failing CI checks for snap-tests and linting. The update aimed to create standard Linux folders for bare base configurations.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The contribution added the base-files slice to bare bases for standard Linux directories. Inactivity and zero comments indicate it was abandoned.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#953 sources: refactor base sources into new package. snapcraft closed Closed unmerged after review changes; successor PR snapcraft#957 completed the Base and FileBase extraction in commit 1d34e9e6b.
74%
#6187 Fix snapcraft try error to show actual base snapcraft closed Closed unmerged over contribution-guideline concerns; PR #6193 later fixed #6186 by using the effective project base in commit bcae1c3ed.
70%