sources: refactor base sources into new package.
Metadata
Current evaluation
Closed without merging after review requested changes. The base sources refactoring was abandoned or superseded by subsequent PRs, as the author noted this was the first in a series.
Suggested action: —
No scores available.
Issue body
This PR makes progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by moving `snapcraft/internal/sources.py` into the `sources` package, and extracting `Base` and `FileBase` into their own module. This is the first in a series of PRs; subsequent onces will refactor the other sources into their own modules.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging after review requested changes. The base sources refactoring was abandoned or superseded by subsequent PRs, as the author noted this was the first in a series. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactoring moving base sources to a new sources package, extracting Base and FileBase modules. Changes passed code coverage and test re-runs, laying groundwork for subsequent source refactors. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Refactored base sources into a new package, extracting Base and FileBase modules. Passed code coverage and xenial autopkg tests. Marks the first step in a broader series of source module refactoring efforts. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #957 sources: refactor base sources into module. | snapcraft | merged | Merged following two approvals and passing CI checks. Refactored Base and FileBase sources into sources/_base.py, increasing test coverage by 1.20% and progressing work on Launchpad bug #1648906. | |
| #1104 repo: refactor into package. | snapcraft | closed | Closed and abandoned without merging. The maintainer commented that the repository refactoring was no longer needed, halting the review process. | |
| #1648906 Sources are getting difficult to maintain | snapcraft (launchpad) | closed | Closed without resolution. The proposal to refactor sources.py into a package was abandoned due to inactivity, with no comments or implementation recorded. | |
| #1673448 refactor repo into its own package | snapcraft (launchpad) | closed | Closed without resolution or comments. The repository refactor into a standalone package was abandoned or superseded by other work. | |
| #765 feat: add feature/pro-sources sources | rockcraft | closed | Closed without merging. The PR to add feature/pro-sources sources received no reviews or comments and was abandoned after 80 days of inactivity. |