sources: refactor base sources into new package.
Metadata
Current evaluation
Closed unmerged after review changes; successor PR snapcraft#957 completed the Base and FileBase extraction in commit 1d34e9e6b.
Resolution: closed superseded
Reason: PR #953 was replaced by merged PR #957, which moved Base and FileBase into sources/_base.py and advanced Launchpad #1648906.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR makes progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by moving `snapcraft/internal/sources.py` into the `sources` package, and extracting `Base` and `FileBase` into their own module. This is the first in a series of PRs; subsequent onces will refactor the other sources into their own modules.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after review changes; successor PR snapcraft#957 completed the Base and FileBase extraction in commit 1d34e9e6b. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after review requested changes. The base-source extraction was completed by merged PR #957 (commit 1d34e9e6b), moving Base and FileBase into sources/_base.py. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging after review requested changes. The base sources refactoring was abandoned or superseded by subsequent PRs, as the author noted this was the first in a series. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactoring moving base sources to a new sources package, extracting Base and FileBase modules. Changes passed code coverage and test re-runs, laying groundwork for subsequent source refactors. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#957
(confidence 99%)
Merged successor implementing the base-source refactor in commit 1d34e9e6b.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #957 sources: refactor base sources into module. | snapcraft | merged | Merged as commit 1d34e9e6b, extracting Base and FileBase into sources/_base.py and advancing the Launchpad #1648906 sources refactor. | |
| #6187 Fix snapcraft try error to show actual base | snapcraft | closed | Closed unmerged over contribution-guideline concerns; PR #6193 later fixed #6186 by using the effective project base in commit bcae1c3ed. | |
| #888 Feat: Add base-files and unit tests | rockcraft | closed | Closed unmerged: the approved base-files change never landed after snap-tests and lint/files failed; no resolving or superseding PR or commit was identified. | |
| #1192 repo: refactor into a package. | snapcraft | merged | Merged as 1e2cd8a2e, refactoring snapcraft.repo into a package and making BaseRepo easier to extend for non-apt/deb functionality. | |
| #955 sources: convert to package. | snapcraft | merged | Merged PR #955 (commit 0ef7dc218) converted snapcraft/internal/sources.py into a package, groundwork for LP bug #1648906. Follow-ups #957 and #961-#970 then split each source handler into its own module. |