← Back to issue list

docs: broken common.mk default target

View original Github issue

Metadata

Project
rockcraft
Number
#941
Type
issue
State
closed
Author
lczyk
Labels
Type: Documentation
Created
Updated
Closed

Current evaluation

Fixed broken help target formatting in common.mk by removing an unnecessary sed command from the parsing pipeline. The change restores correct alignment for make targets and descriptions.

Suggested action:

No scores available.

Issue body

### Bug Description the output of the default target (aka `help`) of `common.mk` does not appear quite right: ``` Target | Description ------------------------------ + ------------------------------------------------ └ | └ ##- Check spelling with codespell └ | └ ##- Format files with prettier └ | └ ##- Lint files with prettier └ | └ ##- Automatically format with ruff └ | └ ##- Lint with ruff └ | └ install-build-deps ##- Set up a testing environment for Tiobe TICS └ | └ ##- Check that uv.lock matches expectations from pyproject.toml └ | └ ##- Set up pre-commit hooks in this repository. └ | └ _setup-docs _setup-lint _setup-tests setup-precommit install-build-deps ## Set up a development environment └ | └ ##- Lint Python packages with twine | Build and host docs with sphinx-autobuild | Build documentation | Clean up the development environment | Generate coverage report | Run all tests └ | └ Build packages for pip (sdist, wheel) └ | └ Check types with mypy └ | └ Check types with pyright └ | └ Fix spelling issues with codespell └ | └ Format the entire repository using pre-commit └ | └ Identify slow tests. Set cutoff time in seconds with SLOW_CUTOFF_TIME └ | └ Lint shell scripts └ | └ Lint the documentation └ | └ Run fast tests └ | └ Run slow tests | Show this help. └ | └ ##- Set up a documentation-only environment └ | └ ##- Set up a linting-only environment └ | └ ##- Set up a testing environment without linters ``` ### To Reproduce ``` git clone https://github.com/canonical/rockcraft && cd rockcraft make -f common.mk ``` ``` make: 4.4.1 ubuntu 25.04 aarch64 ```

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Fixed broken help target formatting in common.mk by removing an unnecessary sed command from the parsing pipeline. The change restores correct alignment for make targets and descriptions.
qwen/qwen3.6-35b-a3b Fixed by removing an unnecessary sed command from the common.mk help target pipeline. The change corrects malformed make help output by simplifying the text processing chain.
qwen/qwen3.6-35b-a3b The broken formatting in the common.mk help target was resolved by removing an unnecessary sed expression. The contributor submitted a patch that corrected the output, and the issue was closed as fixed.
qwen3.6-35b-a3b-mtp-q6 Fixed malformed make help output in common.mk by removing a redundant sed substitution from the help target. The contributor verified the change resolves the formatting issue, and the issue was closed.
qwen3.6-35b-a3b-mtp-q6 The broken make help output in common.mk was fixed by removing the unnecessary sed substitution s/^[^:]*:// from the target pipeline. The contributor confirmed the patch resolves the formatting issue, and the report was closed.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1105 fix: correct common.mk help target listing rockcraft merged Merged a fix for common.mk help target listing by preserving target names during Makefile parsing, resolving issue #941. Approved by three reviewers and merged after unrelated CI failures were confirmed as environmental noise.
76%