fix: correct common.mk help target listing
Metadata
Current evaluation
Merged PR #1105 as commit 6ae769e9, preserving Makefile target names in common.mk help output and fixing #941.
Resolution: closed resolved
Reason: PR #1105 merged into main via commit 6ae769e9. Its parsing fix preserves complete target names in help output, resolving #941.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fix common.mk help output by preserving target names when parsing Makefile entries.
Fixes #941.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1105 as commit 6ae769e9, preserving Makefile target names in common.mk help output and fixing #941. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into rockcraft main via #1105 (commit 6ae769e9), preserving Makefile target names in common.mk help output and fixing #941. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#1105 (commit 6ae769e9), preserving Makefile target names in common.mk help output and fixing #941. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for common.mk help target listing by preserving target names during Makefile parsing, resolving issue #941. Approved by three reviewers and merged after unrelated CI failures were confirmed as environmental noise. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Fixes common.mk help output by preserving target names during Makefile parsing. Changes were squashed to a single commit per review. Unrelated CI failures were dismissed as environment drift, allowing the merge. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
rockcraft#941
(confidence 100%)
PR #1105 explicitly fixes the broken common.mk default help target reported in #941.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #941 docs: broken common.mk default target | rockcraft | closed | Fixed the common.mk help output, which showed empty Target names. PR #1105 (commit 6ae769e9) removed a faulty sed prefix-strip expression, based on the reporter lczyk's diff. | |
| #542 fix: harden 'make help' for shell portability | starbase | merged | Merged PR #542 as commit 3754b6a, hardening common.mk's help target for shell portability and fixing #538. | |
| #332 fix(common.mk): fix glob of prettier files | starbase | merged | Merged PR #332 corrected the Prettier file glob in common.mk; landed as commit 3b7289b. | |
| #501 fix: help formatting when running `make -f common.mk` | starbase | merged | Merged PR canonical/starbase#501 (commit 0344506) fixing help output formatting when running `make -f common.mk`; upported from canonical/rockcraft#1105. Approved by 2 reviewers, all CI checks passed. |