← Back to issue list

fix: correct common.mk help target listing

View original Github issue

Metadata

Project
rockcraft
Number
#1105
Type
pull request
State
merged
Author
gcomneno
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for common.mk help target listing by preserving target names during Makefile parsing, resolving issue #941. Approved by three reviewers and merged after unrelated CI failures were confirmed as environmental noise.

Suggested action:

No scores available.

Issue body

Fix common.mk help output by preserving target names when parsing Makefile entries. Fixes #941.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for common.mk help target listing by preserving target names during Makefile parsing, resolving issue #941. Approved by three reviewers and merged after unrelated CI failures were confirmed as environmental noise.
qwen3.6-35b-a3b-mtp-q6 Merged. Fixes common.mk help output by preserving target names during Makefile parsing. Changes were squashed to a single commit per review. Unrelated CI failures were dismissed as environment drift, allowing the merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#501 fix: help formatting when running `make -f common.mk` starbase merged Merged upstream fix for help formatting when running make -f common.mk. Approved by two reviewers, passed all CI checks, and resolved via a single-line change.
79%
#324 fix(common.mk): docs ignores starbase merged Merged a single-line update to common.mk that corrects documentation ignore patterns. The change received approval from two reviewers, passed CI validation, and implements fixes referenced in PR #2096.
77%
#941 docs: broken common.mk default target rockcraft closed Fixed broken help target formatting in common.mk by removing an unnecessary sed command from the parsing pipeline. The change restores correct alignment for make targets and descriptions.
76%
#332 fix(common.mk): fix glob of prettier files starbase merged Merged a one-line update to common.mk that corrected the glob pattern for prettier files. Approved by one reviewer, the change was successfully integrated with zero unresolved comments and no CI failures.
74%
#2056 fix(common.mk): get upstream setup-lint charmcraft merged Merged a fix to restore the upstream setup-lint target in common.mk after a pyright dependency removal caused a regression. Approved by two reviewers with zero unresolved comments.
72%