← Back to issue list

snapcraft push returns non exit zero code if snap requires manual review

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1743587
Type
issue
State
open
Author
~serge-borovkov
Labels
Created
Updated
Closed

Current evaluation

snapcraft push returns non-zero exit code when a snap requires manual review despite successful upload; reporter expects zero exit code. Unlabeled, zero comments, inactive for over eight years.

Suggested action: needs triage

Reason: The issue is unlabelled with zero maintainer comments and has been inactive for over eight years. The related commit 85765674a improved the error message for manual review hints but did not change the exit code behavior, so the underlying concern about non-zero exit on successful upload with manual review may still be relevant. However, the push command has since been renamed to upload in the codebase, and the current behavior needs verification against the modern upload command before deciding whether this is still a bug or working as intended.

Impact: 35 Quick Win: 24.5 Staleness: 95 Complexity: 30 Confidence: 65 Support Request: 20

Issue body

snapcraft push returns non exit zero code if snap requires manual review. Snap's upload itself succeeds. I would expect snapcraft release to fail here but snapcraft push to return zero exit code.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 35
Quick Win: 24.5
Staleness: 95
Complexity: 30
Confidence: 65
Support Request: 20
needs triage snapcraft push returns non-zero exit code when a snap requires manual review despite successful upload; reporter expects zero exit code. Unlabeled, zero comments, inactive for over eight years.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 10
Confidence: 85
Support Request: 5
close stale Reports snapcraft push returning non-zero exit code when a snap requires manual review despite successful upload. Author expects zero exit code. Unlabeled, zero comments, inactive for over eight years.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 15
Confidence: 90
Support Request: 10
close stale snapcraft push returns non-zero exit code when a snap requires manual review. The report lacks maintainer engagement, labels, or comments, and remains untriaged.
qwen3.6-35b-a3b-mtp-q6
Staleness: 98
Complexity: 15
Confidence: 90
Support Request: 10
close stale Issue reports snapcraft push returning non-zero exit code when a snap requires manual review, despite successful upload. Author expects zero exit code for push. Unlabeled, no maintainer response, inactive for ~8.5 years.
qwen3.6-35b-moe-q4
Staleness: 98
Complexity: 10
Confidence: 85
Support Request: 5
close stale snapcraft push returns non-zero exit code when a snap requires manual review, despite successful upload. Author expects zero exit code for push. No maintainer interaction, open for over 8 years.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1261 (confidence 55%)

    Commit 85765674a improved the error message for manual review hints, which is directly related to the manual review status handling mentioned in this issue.

Related issues

Issue Project State Summary Similarity
#1863430 unhelpful failure message snapcraft (launchpad) open Snapcraft push shows only a CalledProcessError traceback when the review-tools check fails, hiding the actual review output. Unlabeled, zero comments, inactive ~5.7 years; the review-tools code path has since been removed from snapcraft.
75%