unhelpful failure message
Metadata
Current evaluation
Snapcraft push shows only a CalledProcessError traceback when the review-tools check fails, hiding the actual review output. Unlabeled, zero comments, inactive ~5.7 years; the review-tools code path has since been removed from snapcraft.
Suggested action: close stale
Reason: The issue is ~6.5 years old with zero comments, no labels, and last activity 2096 days ago, and the exact code path in the traceback (snapcraft 3.9.1's snapcraft/internal/review_tools/_runner.py and snapcraft/cli/_review.py) no longer exists in the current tree, which now has snapcraft/linters/ and snapcraft/store/ instead. The review-tools failure mode is therefore no longer reproducible in modern snapcraft, so the issue is both inactive and obsolete rather than merely old.
Impact:
20
Quick Win:
17.0
Staleness:
95
Complexity:
15
Confidence:
70
Support Request:
10
Issue body
see https://github.com/casperdcl/cdcl/runs/447883745#step:6:20
The output is very unhelpful; doesn't actually say what the error was.
Preparing to push 'gh_0.5.5-pre.1-55-gd7181b1_amd64.snap'.
After pushing, the resulting snap revision will be released to 'edge' when it passes the Snap Store review.
Running the review tools before pushing this snap to the Snap Store.
Sorry, an error occurred in Snapcraft:
Command '['/snap/bin/review-tools.snap-review', '/home/runner/work/cdcl/cdcl/cli/gh_0.5.5-pre.1-55-gd7181b1_amd64.snap', '--json']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/snap/snapcraft/3970/bin/snapcraft", line 11, in <module>
load_entry_point('snapcraft==3.9.1', 'console_scripts', 'snapcraft')()
File "/snap/snapcraft/3970/lib/python3.6/site-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "/snap/snapcraft/3970/lib/python3.6/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/snap/snapcraft/3970/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/snap/snapcraft/3970/lib/python3.6/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/snap/snapcraft/3970/lib/python3.6/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/snap/snapcraft/3970/lib/python3.6/site-packages/snapcraft/cli/store.py", line 176, in push
review_snap(snap_file=snap_file)
File "/snap/snapcraft/3970/lib/python3.6/site-packages/snapcraft/cli/_review.py", line 33, in review_snap
review_tools.run(snap_filename=snap_file)
File "/snap/snapcraft/3970/lib/python3.6/site-packages/snapcraft/internal/review_tools/_runner.py", line 38, in run
subprocess.check_output(command, stderr=subprocess.STDOUT, env=env)
File "/snap/snapcraft/3970/usr/lib/python3.6/subprocess.py", line 356, in check_output
**kwargs).stdout
File "/snap/snapcraft/3970/usr/lib/python3.6/subprocess.py", line 438, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/snap/bin/review-tools.snap-review', '/home/runner/work/cdcl/cdcl/cli/gh_0.5.5-pre.1-55-gd7181b1_amd64.snap', '--json']' returned non-zero exit status 1.
You can find the traceback in file '/tmp/tmpwvm3sl16/trace.txt'.
##[error]Process completed with exit code 1.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.8-27b |
Impact:
20
Quick Win:
17.0
Staleness:
95
Complexity:
15
Confidence:
70
Support Request:
10
|
close stale | Snapcraft push shows only a CalledProcessError traceback when the review-tools check fails, hiding the actual review output. Unlabeled, zero comments, inactive ~5.7 years; the review-tools code path has since been removed from snapcraft. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
98
Complexity:
15
Confidence:
90
Support Request:
10
|
close stale | Reports unhelpful Snapcraft error output during push, masking the actual review tool failure. Inactive for over 6 years with no maintainer response or labels. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
95
Complexity:
25
Confidence:
85
Support Request:
10
|
close stale | Unhelpful error output when Snapcraft push fails. Issue is over 6 years old, unlabelled, and references outdated Snapcraft 3.9.1 with zero maintainer engagement. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
95
Complexity:
15
Confidence:
85
Support Request:
10
|
close stale | Reports snapcraft producing a generic traceback instead of a clear error message when the snap-review subprocess fails. Untriaged and inactive for over five years. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
95
Complexity:
20
Confidence:
80
Support Request:
5
|
close stale | Reports unhelpful error output from snapcraft when review-tools.snap-review fails during push. No maintainer response, no labels, inactive for over 5 years. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1743587 snapcraft push returns non exit zero code if snap requires manual review | snapcraft (launchpad) | open | snapcraft push returns non-zero exit code when a snap requires manual review despite successful upload; reporter expects zero exit code. Unlabeled, zero comments, inactive for over eight years. |