snapcraft is mixing the string literals, some with ' and some with "
Metadata
Current evaluation
Style issue about mixed string quote styles was moved from Launchpad to GitHub ubuntu-core/snapcraft#25 and fixed by PR #65 (commit 21d9497), merged as 06c8a88, replacing double quotes with single quotes across the codebase.
Resolution: closed resolved
Reason: The reporter redirected the issue to GitHub ubuntu-core/snapcraft#25 and commented on 2015-11-24 that it was fixed by ubuntu-core/snapcraft#65. Commit 21d949767 'Replaced the double quotes by single quotes on strings' was merged to master via merge commit 06c8a88be.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Consistency is important, specially in the python world :)
So we should stick with only one form of string literals. Most of the canonical projects prefer single quotes.
So instead of "hello", use 'hello'
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Style issue about mixed string quote styles was moved from Launchpad to GitHub ubuntu-core/snapcraft#25 and fixed by PR #65 (commit 21d9497), merged as 06c8a88, replacing double quotes with single quotes across the codebase. | |
| stealth/space-bunny-alpha | — | closed resolved | Style inconsistency of mixed single/double-quoted Python strings. Tracked as ubuntu-core/snapcraft#25 and fixed by merged PR #65 (commit 21d949767, "Replaced the double quotes by single quotes on strings.") from elopio/quotes. | |
| stealth/space-bunny-alpha | — | closed resolved | Python strings were standardized to single quotes by merged PR #65 (commit 21d949767), resolving inconsistent double- and single-quote usage. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. The suggestion to standardize Python string literals to single quotes was abandoned, likely superseded by modern linting tools or updated project style guides. | |
| qwen/qwen3.6-35b-a3b | — | — | The proposal to standardize on single-quote string literals in snapcraft was closed without implementation or discussion. The change was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed with no comments or resolution. The proposal to standardize on single quotes was abandoned or superseded by automated linting. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without action. The request to enforce single quotes for Python string literals was abandoned, likely superseded by updated project style guidelines and automated linting. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#65
(confidence 97%)
PR elopio/quotes; commit 21d949767 merged as 06c8a88be.
-
Duplicate Of:
canonical/snapcraft#25
(confidence 95%)
Launchpad issue was migrated verbatim to GitHub ubuntu-core/snapcraft#25 with the same title.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #25 snapcraft is mixing the string literals, some with ' and some with " | snapcraft | closed | Standardized Python string literals to single quotes via merged PR #65 (commit 21d949767; merge 06c8a88be). | |
| #1477638 snapcraft uses % to format strings | snapcraft (launchpad) | closed | Replaced legacy % string formatting with str.format in ubuntu-core/snapcraft PR #72 after tracking moved to GitHub issue #34. |