← Back to issue list

Replaced the double quotes by single quotes on strings.

View original Github issue

Metadata

Project
snapcraft
Number
#65
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged via commit 21d949767 (merge 06c8a88be), standardising Python string literals to single quotes across 21 files (+148/-148), closing the mixed-quote style issue #25.

Resolution: closed resolved

Reason: PR #65 by maintainer come-maiz was merged into master as commit 21d949767 ('Replaced the double quotes by single quotes on strings.', merge commit 06c8a88be). It explicitly closes issue #25 and updates the coverage script/tests to exclude plainbox from coveralls reporting.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Closes #25. Consistency ftw!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged via commit 21d949767 (merge 06c8a88be), standardising Python string literals to single quotes across 21 files (+148/-148), closing the mixed-quote style issue #25.
stealth/space-bunny-alpha — closed resolved PR #65 merged (commit 21d949767, merge 06c8a88be) converting double-quoted strings to single quotes across 21 files (+148/-148), closing the mixed string-literal issue #25. Coverage complaints in review deferred.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#65 via commit 21d949767, standardizing string literals to single quotes and closing #25.
qwen/qwen3.6-35b-a3b — — Merged a pull request replacing double quotes with single quotes across 21 files for consistency, closing issue #25. Reviewers noted a minor coverage drop, resolved by excluding plainbox tests from coverage reporting.
qwen3.6-35b-a3b-mtp-q6 — — Merged a code style update replacing double quotes with single quotes for string consistency, resolving issue #25. Coverage discrepancies were addressed by adjusting test configurations to exclude plainbox tests from coverage reporting.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#25 (confidence 98%)

    Issue 'snapcraft is mixing the string literals' was closed by this PR, as stated in its description.

  • Related To: snapcraft#521 (confidence 35%)

    Later commit 465c38817 corrects the autotools tests that the review thread asked to add.

Related issues

No related issues found above the similarity threshold.