← Back to issue list

Copy plugin should follow symlinks that point outside of the snap

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1532515
Type
issue
State
closed
Author
~renat2017
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#426 (commit b332715a8): the copy plugin now follows absolute and part-external symlinks so copied targets remain valid inside the snap.

Resolution: closed resolved

Reason: The maintainer linked the fix to merged PR canonical/snapcraft#426, which landed as commit b332715a8 and explicitly fixed LP bug #1532515.

Evaluated by: mr-cal-bot

No scores available.

Issue body

We need the option to copy symlinks as symlinks with their metadata in the copy plugin. Here is the possible solution. https://github.com/ubuntu-core/snapcraft/pull/209

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#426 (commit b332715a8): the copy plugin now follows absolute and part-external symlinks so copied targets remain valid inside the snap.
stealth/space-bunny-alpha — closed resolved Landed in merged PR #426 (commit b332715a8): the copy plugin now follows absolute symlinks and those pointing outside the part's install dir so they stay valid in the snap. Fixes LP #1532515.
stealth/space-bunny-alpha — closed resolved Implemented external-symlink handling in canonical/snapcraft#426 (commit b332715a8), following absolute and out-of-part links rather than preserving them.
qwen/qwen3.6-35b-a3b — — Closed without resolution. PR #209 was proposed to copy symlinks with metadata but received no comments. Extended inactivity indicates the request was abandoned or superseded.
qwen/qwen3.6-35b-a3b — — Resolved via PR #209, which implements symlink copying with metadata support for the copy plugin.
qwen/qwen3.6-35b-a3b — — Closed with a linked PR proposed as a solution. The feature request was abandoned without explicit resolution or merge confirmation.
qwen3.6-35b-a3b-mtp-q6 — — Closed and abandoned. The request to copy symlinks with metadata was linked to PR #209 as a proposed fix, but no implementation occurred and the pull request was not merged.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#426 (confidence 100%)

    Merged PR implementing external-symlink handling for the copy plugin.

Related issues

Issue Project State Summary Similarity
#426 Copy plugin: Follow symlinks if outside of snap. snapcraft merged Merged in canonical/snapcraft#426 (b332715a8), following absolute or out-of-part symlinks to prevent broken links and fix LP #1532515.
88%
#209 Added symlinks option to the copy plugin snapcraft closed Closed unmerged in favor of redesigning copy-plugin symlink handling; commit b332715a8 later added following for symlinks pointing outside the snap.
79%
#1658774 Symlinks to libc are followed by the dump and copy plugins snapcraft (launchpad) closed Merged snapcraft#1174 as commit 2b8bac953, changing copy and dump plugins to ignore staged-package symlinks to libc instead of following or removing them.
72%