← Back to issue list

Added symlinks option to the copy plugin

View original Github issue

Metadata

Project
snapcraft
Number
#209
Type
pull request
State
closed
Author
renatgalimov
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged in favor of redesigning copy-plugin symlink handling; commit b332715a8 later added following for symlinks pointing outside the snap.

Resolution: closed superseded

Reason: Maintainer kyrofa closed the PR on 2016-03-31 pending a redesign and invited a new submission. Commit b332715a8 subsequently implemented the proposed behavior for external symlinks.

Evaluated by: mr-cal-bot

No scores available.

Issue body

We need this change since we need to copy large directories. Please, consider adding this change to your codebase. Thank you, Renat

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of redesigning copy-plugin symlink handling; commit b332715a8 later added following for symlinks pointing outside the snap.
stealth/space-bunny-alpha — closed stale Closed unmerged on 2016-03-31 after maintainers rejected the symlink option and requested a redesign that preserves in-snap links but follows absolute or external links.
stealth/space-bunny-alpha — closed stale Closed unmerged after maintainers rejected a simple symlinks option in favor of redesigning copy-plugin symlink handling; the contributor was invited to continue with a new PR.
qwen/qwen3.6-35b-a3b — — Closed without merging. Maintainer declined the symlink option, proposing a complete redesign of the copy plugin's symlink handling instead. Contributor was invited to reopen or submit a new PR if they wish to implement the proposed approach.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. Maintainers declined the symlink option, planning instead to redesign the copy plugin's symlink handling logic entirely. Contributors were asked to reopen or submit a new PR if they wish to continue development under the new approach.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1532515 Copy plugin should follow symlinks that point outside of the snap snapcraft (launchpad) closed Merged in canonical/snapcraft#426 (commit b332715a8): the copy plugin now follows absolute and part-external symlinks so copied targets remain valid inside the snap.
79%
#426 Copy plugin: Follow symlinks if outside of snap. snapcraft merged Merged in canonical/snapcraft#426 (b332715a8), following absolute or out-of-part symlinks to prevent broken links and fix LP #1532515.
76%
#1658774 Symlinks to libc are followed by the dump and copy plugins snapcraft (launchpad) closed Merged snapcraft#1174 as commit 2b8bac953, changing copy and dump plugins to ignore staged-package symlinks to libc instead of following or removing them.
74%
#1174 copy, dump plugin: ignore symlinks to libc. snapcraft merged Merged as 2b8bac953: copy and dump plugins now ignore, rather than follow or remove, staged-package symlinks to libc.
71%