← Back to issue list

Missing integration tests for login/logout/upload

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1541391
Type
issue
State
closed
Author
~kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Added integration coverage for Snapcraft's store-facing login, logout, and upload flows in ubuntu-core/snapcraft#302, linked in the issue's final discussion.

Resolution: closed resolved

Reason: PR ubuntu-core/snapcraft#302 addressed the missing store integration tests. Maintainer elopio linked that PR in the final issue comment before closure.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The store-touching bits of code in Snapcraft (login/logout/upload) are lacking integration tests. This causes bugs to slip through the cracks.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Added integration coverage for Snapcraft's store-facing login, logout, and upload flows in ubuntu-core/snapcraft#302, linked in the issue's final discussion.
stealth/space-bunny-alpha — closed resolved Added store-flow integration tests: login/logout in canonical/snapcraft#302 (2491ba82c) and successful upload in #304 (b1afa6cfc).
stealth/space-bunny-alpha — closed resolved Store code lacked integration tests. Maintainer elopio linked PR #302 (login/logout tests, commit 2491ba82c, merge ac24229e3); upload coverage followed in PR #304 (b1afa6cfc, merge 12ea244f3), closing the gap.
stealth/space-bunny-alpha — closed resolved Login/logout integration tests landed in #302 (2491ba82c), and successful-upload coverage landed in #304 (b1afa6cfc), providing the requested coverage.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The request to add integration tests for login, logout, and upload operations was abandoned due to age and lack of follow-up.
qwen/qwen3.6-35b-a3b — — Closed without implementation due to prolonged inactivity. The request for integration tests covering Snapcraft login, logout, and upload was abandoned after over ten years with no discussion.

Update history

Date Change
created

Related work

  • Likely Fixed By: ubuntu-core/snapcraft#302 (confidence 95%)

    The sole issue comment identifies PR #302 as the work addressing the missing login, logout, and upload integration tests.

Related issues

Issue Project State Summary Similarity
#300 integration-tests: add login and logout tests snapcraft closed Superseded by canonical/snapcraft#302, which merged the login/logout integration tests in commit 2491ba82c (merge ac24229e3).
82%
#302 integration-tests: add login and logout tests snapcraft merged PR #302 merged into ubuntu-core/test/upload via commit 2491ba82c (merge ac24229e3), adding login/logout integration tests; maintainers noted the tests only run on upstream/master branches since Travis encrypted vars are unavailable to external PRs.
74%
#304 integration_tests: add a successful upload test snapcraft merged Merged PR #304 added successful-upload integration coverage in commit b1afa6cfc (merge 12ea244f3), building on prerequisite login/logout tests from #302.
72%
#1542 tests: add integration tests for build snaps snapcraft merged PR #1542 merged as 8c9900f38, adding integration coverage for build snaps; two scenarios remained excluded due to Launchpad bugs #1716054 and #1716055.
71%
#783 Add an integration test for autotools snapcraft merged Merged snapcraft#783 in commit 874b28041, adding integration-test coverage for the Autotools plugin and resolving LP bug #1621694.
71%
#706 Add integration tests using the snap charmcraft closed Snap-based integration coverage was added through Charmcraft's Spread suite by merged PR canonical/charmcraft#862 (commit 7790c044).
71%