← Back to issue list

integration-tests: add login and logout tests

View original Github issue

Metadata

Project
snapcraft
Number
#302
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

PR #302 merged into ubuntu-core/test/upload via commit 2491ba82c (merge ac24229e3), adding login/logout integration tests; maintainers noted the tests only run on upstream/master branches since Travis encrypted vars are unavailable to external PRs.

Resolution: closed resolved

Reason: The pull request itself was merged into the test/upload branch: commit 2491ba82c 'integration-tests: add login and logout tests' landed via merge commit ac24229e3 ('Merge pull request #302 from ubuntu-core/test/upload'). kyrofa approved the +88/-3 test addition; the CI caveat about encrypted env vars was accepted as a known limitation, not a blocker.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #302 merged into ubuntu-core/test/upload via commit 2491ba82c (merge ac24229e3), adding login/logout integration tests; maintainers noted the tests only run on upstream/master branches since Travis encrypted vars are unavailable to external PRs.
stealth/space-bunny-alpha — closed resolved Merged #302 added login/logout integration tests in commit 2491ba82c (merge ac24229e3); external PR CI lacks encrypted credentials, limiting execution to upstream branches or master.
qwen/qwen3.6-35b-a3b — — Merged addition of login and logout integration tests. Encrypted environment variables fail for external PRs, restricting test execution to upstream branches or master. Changes were approved and merged despite this CI limitation.
qwen3.6-35b-a3b-mtp-q6 — — Merged after reviewer approval. Added login and logout integration tests. Encrypted environment variables are unavailable for external PRs, so tests only run on upstream branches or master due to Travis CI limitations.

Update history

No update history recorded yet.

Related work

  • Related To: travis-ci#1946 (confidence 70%)

    Upstream Travis issue on encrypted variables for PR builds; the author tracked it as the blocker preventing the coveralls/login credentials from working on external PRs.

Related issues

Issue Project State Summary Similarity
#300 integration-tests: add login and logout tests snapcraft closed Superseded by canonical/snapcraft#302, which merged the login/logout integration tests in commit 2491ba82c (merge ac24229e3).
82%
#304 integration_tests: add a successful upload test snapcraft merged Merged PR #304 added successful-upload integration coverage in commit b1afa6cfc (merge 12ea244f3), building on prerequisite login/logout tests from #302.
80%
#1541391 Missing integration tests for login/logout/upload snapcraft (launchpad) closed Added integration coverage for Snapcraft's store-facing login, logout, and upload flows in ubuntu-core/snapcraft#302, linked in the issue's final discussion.
74%