← Back to issue list

nodejs plugin needs to be able to build using gulpfiles

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1575880
Type
issue
State
closed
Author
~sergiusens
Labels
verification-done
Created
Updated
Closed

Current evaluation

Resolved by merged PR #563 (commit 00079ee32, "New plugin: gulp"), which added a standalone gulp plugin instead of extending nodejs. Shipped in snapcraft 2.12 to xenial; verified by ~elopio using integration_tests/snaps/simple-gulp.

Resolution: closed resolved

Reason: A standalone gulp plugin was merged in PR #563 (commit 00079ee32 "New plugin: gulp") after discussion moved it out of the nodejs plugin. The SRU of snapcraft 2.12 to xenial-proposed was verified by ~elopio on 2016-06-28 with the simple-gulp integration test snap, and the bug was tagged verification-done.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Gulp needs to be supported as a build driver [Impact] * It is not easy to make a snap from a project that uses gulp. [Test Case] * define a snapcraft.yaml for a project that uses gulp. * run snapcraft, install the snap and execute it. [Regression Potential] * None, this is a new plugin.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved by merged PR #563 (commit 00079ee32, "New plugin: gulp"), which added a standalone gulp plugin instead of extending nodejs. Shipped in snapcraft 2.12 to xenial; verified by ~elopio using integration_tests/snaps/simple-gulp.
stealth/space-bunny-alpha — closed resolved Added a dedicated Gulp plugin in canonical/snapcraft#563 (commit 00079ee32), released in Snapcraft 2.12 and verified successfully on Xenial.
stealth/space-bunny-alpha — closed resolved Added a dedicated gulp plugin, merged in canonical/snapcraft#563 (commit 00079ee32), and included it in the 2.12 release changelog.
stealth/space-bunny-alpha — closed resolved Added a dedicated Gulp build plugin with integration-test coverage in merged PR #563 (commit 00079ee32), enabling builds for projects using gulpfiles.
qwen/qwen3.6-35b-a3b — — Gulp support was added to the nodejs plugin. The enhancement was implemented, verified, and the issue closed.
qwen/qwen3.6-35b-a3b — — The nodejs plugin was updated to support Gulp as a build driver. The feature was implemented and verified, resolving the request.
qwen/qwen3.6-35b-a3b — — Gulp support was added to the nodejs plugin. The feature was implemented, verified, and the issue was closed.
qwen3.6-35b-a3b-mtp-q6 — — Gulp build support was implemented for the nodejs plugin. The feature was verified and the issue closed.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcraft#563 (confidence 95%)

    PR referenced by maintainer ~sergiusens in the final comment; commit 00079ee32 'New plugin: gulp' landed it.

  • Related To: snapcraft#782 (confidence 80%)

    Later commit e68413299 'gulp plugin: fix the npm install prefix' improves the same plugin.

  • Related To: snapcraft#998 (confidence 80%)

    Commit acf95e174 updates the gulp plugin to get_build_properties()/get_pull_properties().

  • Caused By: snapcraft (launchpad)#1596762 (confidence 60%)

    Follow-up bug (gulp-tasks property required) reported by ~elopio during verification; assessed as non-blocking.

Related issues

Issue Project State Summary Similarity
#1518403 nodejs plugin snapcraft (launchpad) closed Node.js plugin added via merged PR ubuntu-core/snapcraft#102 (commits 0336e05fb 'Initial implementation', merge b5ed4d7c0). Maintainer elopio closed the bug, noting the PR includes an example that snapped successfully on CI.
75%
#563 New plugin: gulp snapcraft merged Merged to master as commit 00079ee32, adding the gulp plugin (snapcraft/plugins/gulp.py), a gulp simple-project integration test, and updated plugin-list coverage, closing LP bug #1575880.
74%
#1621921 The gulp plugin installs gulp globally instead of locally to the snap's part snapcraft (launchpad) closed Fixed in canonical/snapcraft#782 via commit e68413299, changing the Gulp plugin to install npm packages into the snap part instead of globally.
70%