← Back to issue list

plugins: update gulp plugin to use get_build_properties() and get_pull_properties()

View original Github issue

Metadata

Project
snapcraft
Number
#998
Type
pull request
State
merged
Author
ZenHarbinger
Labels
—
Created
Updated
Closed

Current evaluation

Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603.

Resolution: closed resolved

Reason: PR #998 was approved and merged into master as commit acf95e174, implementing the Gulp property-hook update with unit and schema coverage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Also updated schema test in unit tests. Added tests for get_pull_properties() and get_build_properties() to test. https://bugs.launchpad.net/snapcraft/+bug/1650603

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603.
stealth/space-bunny-alpha — closed resolved Merged PR #998 updated the Gulp plugin to use get_build_properties() and get_pull_properties(), refreshed its schema test, and added method tests in commit acf95e174.
stealth/space-bunny-alpha — closed resolved Merged #998 to update the gulp plugin to use get_build_properties() and get_pull_properties(), with schema updates and unit tests; addresses Launchpad bug #1650603.
stealth/space-bunny-alpha — closed resolved Merged #998 in commit acf95e174, updating the gulp plugin to use get_build_properties() and get_pull_properties() and adding unit/schema tests for Launchpad bug #1650603.
stealth/space-bunny-alpha — closed resolved Merged PR #998 as acf95e174, updating the Gulp plugin to use get_build_properties() and get_pull_properties(), with schema and unit tests; resolves Launchpad bug #1650603.
qwen/qwen3.6-35b-a3b — — Merged into master. Updates the gulp plugin to use get_build_properties() and get_pull_properties(), adds unit tests, and updates schema tests. Approved and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Updated the gulp plugin to use get_build_properties() and get_pull_properties(), with added unit tests. Coverage remains at 96.35 percent. Resolves Launchpad bug 1650603.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1650603 Update gulp plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests.
83%
#1001 plugins: update catkin plugin to use get_pull_properties() snapcraft merged Merged as commit 561a04341: updated the catkin plugin to use get_pull_properties(), refreshed schema tests, and added unit tests for Launchpad bug #1650628.
80%
#1002 plugins: update python plugin to support get_pull_properties() snapcraft merged Merged as commit dc26a14b2: python plugin gained get_pull_properties() support, with updated schema/unit tests, addressing Launchpad bug #1650626.
79%
#999 Updated autotools plugin to use get_build_properties() snapcraft merged Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608.
77%
#997 plugins: update go plugin to use get_build_properties() snapcraft merged Merged PR #997 as commit 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting schema expectations, and adding helper unit tests.
76%
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c.
76%
#993 plugins: update qmake to use get_build_properties and get_pull_properties() snapcraft merged Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553.
75%
#1022 plugins: update copy plugin to use get_build_properties(). snapcraft merged Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series.
74%
#1650600 Update nodejs plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests.
74%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series.
73%