the config is handled as function in a module
Metadata
Current evaluation
Config handling refactor landed in canonical/snapcraft#519 (commit 17bff69c6), wrapping load/save/get in a Config object after #518; released in snapcraft 2.10/2.10.1 and verified by elopio, closing LP #1586511.
Resolution: closed resolved
Reason: PR #519 'Improve the config handling' was merged as commit 17bff69c6 and shipped in snapcraft 2.10 (and 2.10.1), per the janitor changelog comments; maintainer elopio verified login/upload/logout flows and marked verification-done.
Evaluated by: mr-cal-bot
No scores available.
Issue body
We can improve the config handling by including the save, load and get methods in an object.
This will simplify testing and is cleaner.
[Impact]
* No visual impact for users, the config file will have the same format and same path.
* This change improves the existing code, but also allows us to make an easier landing of the macaroons feature.
[Test Case]
* snapcraft login.
* build a snap.
* snapcraft upload the snap build.
* check that the snap is in the store.
* snapcraft logout.
* try snapcraft upload again.
* check that you get an error.
[Regression Potential]
* The existing features that use the config might fail: login, upload, logout.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Config handling refactor landed in canonical/snapcraft#519 (commit 17bff69c6), wrapping load/save/get in a Config object after #518; released in snapcraft 2.10/2.10.1 and verified by elopio, closing LP #1586511. | |
| stealth/space-bunny-alpha | — | closed resolved | Config refactor shipped in snapcraft 2.10 via merged PR #519 (commit 17bff69c6), grouping save/load/get into a Config object; verified on xenial by ~elopio and fix-confirmed in SRU 2.10.1. | |
| stealth/space-bunny-alpha | — | closed resolved | Config save/load/get handling was refactored into an object for cleaner testing and macaroon readiness; verified and closed with no user-facing changes (LP #1586511). | |
| qwen/qwen3.6-35b-a3b | — | — | Implemented config refactoring into an object to improve testability and support macaroons. Verified and closed without user-facing changes. | |
| qwen/qwen3.6-35b-a3b | — | — | Refactored config handling into an object with save, load, and get methods to improve testability and code cleanliness. The change was implemented, verified, and closed with no user-facing impact. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#519
(confidence 97%)
Merged commit17bff69c6 'Improve the config handling. (#519)' explicitly references LP #1586511 in the 2.10 changelog.
-
Related To:
canonical/snapcraft#518
(confidence 70%)
Prerequisite refactor moving login/logout to a store client, merged before #519.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #519 Improve the config handling. | snapcraft | merged | Config handling was refactored and merged in canonical/snapcraft#519 as commit 17bff69c6 after prerequisite #518; moving config into storeapi remained a possible follow-up. |