log in with one-time password no longer works on master
Metadata
Current evaluation
One-time-password login was restored by #529 (commit 133cae0b0), shipped in Snapcraft 2.10 and verified on xenial with 2FA.
Resolution: closed resolved
Reason: PR ubuntu-core/snapcraft#529 fixed the regression in commit 133cae0b0. The fix shipped in Snapcraft 2.10 and was verified successfully with a 2FA-enabled account.
Evaluated by: mr-cal-bot
No scores available.
Issue body
I made a mistake in the refactoring of the login method, passing the one-time password as token.
This is a regression on master, but it's a branch that landed last week, so it hasn't been released to ubuntu.
[Impact]
* Existing users of the ubuntu package are not affected because the bug has not been released.
* The bug affects all users with two-factor autentication enabled that want to login with snapcraft.
[Test Case]
* set up an account with 2fa.
* run snapcraft login
[Regression Potential]
* Various log in scenarios could be affected.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | One-time-password login was restored by #529 (commit 133cae0b0), shipped in Snapcraft 2.10 and verified on xenial with 2FA. | |
| stealth/space-bunny-alpha | — | closed resolved | Regression in refactored login method passing the one-time password as token broke 2FA logins on master. Fixed by merged PR canonical/snapcraft#529 (commit 133cae0b0), released in snapcraft 2.10+16.10 and verified in 2.10.1. | |
| stealth/space-bunny-alpha | — | closed resolved | One-time-password login was restored by canonical/snapcraft#529 (commit 133cae0b0), fixing the unreleased master regression that passed OTPs as tokens. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed a regression where one-time passwords were incorrectly passed as tokens during login refactoring. The fix was verified and the issue closed. The change remains unreleased on master. | |
| qwen/qwen3.6-35b-a3b | — | — | A login method regression incorrectly passed one-time passwords as tokens, breaking two-factor authentication. The bug was fixed and verified, restoring proper OTP handling for snapcraft logins. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed a regression where one-time passwords failed during login due to a refactoring error. The fix was merged and verified, restoring two-factor authentication functionality for snapcraft users on master. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Fixed a regression where one-time passwords were incorrectly passed as tokens during login refactoring. The fix was verified and the issue closed before the affected code reached Ubuntu releases. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
ubuntu-core/snapcraft#529
(confidence 100%)
Merged as commit 133cae0b0 with the title "Fix the one-time password login."
-
Caused By:
ubuntu-core/snapcraft#518
(confidence 95%)
The login/logout client refactor introduced the regression identified in the issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #529 Fix the one-time password login. | snapcraft | merged | Merged canonical/snapcraft#529, fixing one-time-password login and resolving Launchpad bug #1586832 in commit 133cae0b0. |